Summary

Allow rbt post to update review requests with submit-as option.

Review Request #7195 — Created April 11, 2015 and submitted April 14, 2015, 3:23 p.m.

Information

Owner

halvorlu

Repository

RBTools

Branch

master

Bugs

Depends On

~~7196~~

Commit

02734ba...

Reviewers

Groups

rbtools

People

Description

Previously, rbt post with the submit-as option could only be used for creating review requests, not for updating them. The function guess_existing_review_request_id searched for review requests of the logged-in user, not the user specified by submit-as.
In order to allow updating of review requests that are not yet public, I've proposed a few changes in reviewboard (see #7196). This allows users with the can_submit_as_another_user permission to list nonpublic review requests.

Testing Done


Publishing with rbt post --submit-as=submitter, then updating the review request with rbt post -u --submit-as=submitter both before and after it has been made public
Running unit tests

Issues

Description	From	Last Updated
Blank line between these lines.	chipx86	April 14, 2015, 9:25 a.m.
We're not very consistent in this statement, but we should have one keyword argument per line, really.	chipx86	April 14, 2015, 9:25 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/commands/post.py
    rbtools/utils/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/post.py
    rbtools/utils/review_request.py

rbtools/utils/review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these lines.
```

rbtools/utils/review_request.py (Diff revision 1)

The issue has been resolved. Show all issues

We're not very consistent in this statement, but we should have one keyword argument per line, really.

Change Summary:

Added blank line and written keyword arguments on separate lines.

Commit:

a087cff9e3a822935d46322f28ec97ef5ee6e8f9

02734bae1395deced78c50136bfabe207cecaa42

Diff:

Revision 2 (+18 -8)

Show changes

	rbtools/commands/post.py
	rbtools/utils/review_request.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/post.py
    rbtools/utils/review_request.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/post.py
    rbtools/utils/review_request.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (a56e730)