Summary

[WIP] Add the unreviewed section in my dashboard

Review Request #7193 — Created April 11, 2015 and discarded March 31, 2016, 3:03 p.m.

Information

Owner

seanchain

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Done some front-end work to add the two section to the dashboard, so far functionless, only on the web page.

Testing Done

Issues

Description	From	Last Updated
Col: 1 W293 blank line contains whitespace	reviewbot	April 11, 2015, 10:53 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	April 11, 2015, 10:53 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	April 11, 2015, 10:53 p.m.
Col: 71 W291 trailing whitespace	reviewbot	April 11, 2015, 10:53 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	April 11, 2015, 10:53 p.m.
Col: 71 W291 trailing whitespace	reviewbot	April 11, 2015, 11:08 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	April 11, 2015, 11:08 p.m.
Col: 39 E231 missing whitespace after ','	reviewbot	April 11, 2015, 11:08 p.m.
Col: 39 E231 missing whitespace after ','	reviewbot	April 11, 2015, 11:08 p.m.
Col: 5 E265 block comment should start with '# '	reviewbot	April 11, 2015, 11:08 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	April 11, 2015, 11:08 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	April 11, 2015, 11:08 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	April 12, 2015, 10:04 p.m.
Col: 39 E231 missing whitespace after ','	reviewbot	April 12, 2015, 10:03 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	April 12, 2015, 10:03 p.m.
Col: 39 E231 missing whitespace after ','	reviewbot	April 12, 2015, 10:03 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	April 12, 2015, 10:03 p.m.
Col: 52 E711 comparison to None should be 'if cond is None:'	reviewbot	April 12, 2015, 10:03 p.m.
Col: 56 E711 comparison to None should be 'if cond is None:'	reviewbot	April 12, 2015, 10:03 p.m.
Col: 56 E711 comparison to None should be 'if cond is not None:'	reviewbot	April 12, 2015, 10:03 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	April 12, 2015, 10:03 p.m.
Use single quotes for strings.	brennie	April 13, 2015, 10:04 p.m.
three links? Also this should be formatted as "All", "Open", and "Unreviewed"	brennie	April 13, 2015, 9:46 p.m.
Blank line between these.	brennie	April 13, 2015, 10:04 p.m.
Blank line between these.	brennie	April 13, 2015, 10:04 p.m.
Blank line between these.	brennie	April 13, 2015, 10:04 p.m.
Undo this change.	brennie	April 13, 2015, 10:17 p.m.
Undo this change.	brennie	April 13, 2015, 10:04 p.m.
This doesn't handle the case where status is S or D so this may cause a regression.	brennie	April 17, 2015, 7:36 a.m.
Undo this change.	brennie	April 13, 2015, 10:19 p.m.
Left over from debugging?	brennie	April 13, 2015, 10:03 p.m.
Undo this change.	brennie	April 13, 2015, 10:27 p.m.
Undo this change.	brennie	April 13, 2015, 10:27 p.m.
I don't feel like these are states for a review request. Wouldn't a review request be unreviewed and incoming for …	brennie	April 13, 2015, 9:54 p.m.
Undo this change.	brennie	April 13, 2015, 10:27 p.m.
Undo this change.	brennie	April 14, 2015, 4:25 p.m.
Blank line between two blocks.	brennie	April 13, 2015, 10:02 p.m.
No blank line here.	brennie	April 13, 2015, 10:02 p.m.
Can you format this like so: elif (self.last_review_request_activity_timetamp is not None and old_reviews is None): site_profile.decrement_unreviewed_outgoing_request_count()	brennie	April 13, 2015, 10:02 p.m.
Undo this change.	brennie	April 13, 2015, 10:02 p.m.
Col: 29 E127 continuation line over-indented for visual indent	reviewbot	April 13, 2015, 10:25 p.m.
I don't think this filtering is going to work the way you want it to work. We really can't add …	brennie	April 14, 2015, 7:43 a.m.
See my above comment about why this isn't going to work.	brennie	April 14, 2015, 4:15 p.m.
Undo this change.	brennie	April 14, 2015, 7:43 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	April 14, 2015, 4:19 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	April 14, 2015, 4:19 p.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	April 14, 2015, 4:21 p.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	April 14, 2015, 4:21 p.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	April 17, 2015, 8:01 a.m.
Col: 33 E231 missing whitespace after ','	reviewbot	April 17, 2015, 7:36 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	April 17, 2015, 8 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	April 17, 2015, 8:05 a.m.
Single quotes for these.	brennie	April 19, 2015, 5:57 a.m.
These really aren't needed. We only use things like this for enumerated char fields in the database.	brennie	April 19, 2015, 5:57 a.m.
This should use a named constant.	brennie	April 18, 2015, 10:16 p.m.
This should use a named constant.	brennie	April 18, 2015, 10:16 p.m.
Any particular reason not to import this at the top of the file? If there is a good reason, this …	brennie	April 19, 2015, 5:57 a.m.
Undo this change.	brennie	April 19, 2015, 5:57 a.m.
This logic can be simplified quite a bit. We are doing query = query & other_query in each case, which …	brennie	April 19, 2015, 5:57 a.m.
This should do Q(status=status).	brennie	April 18, 2015, 10:16 p.m.
We should be using named constants for these.	brennie	April 18, 2015, 10:16 p.m.
This should do Q(status=status). Also can we format this as: query = (query & Q(status=status) & Q(last_review_activity_timestamp=None))	brennie	April 18, 2015, 10:16 p.m.
Can we call this last_review or last_review_timestamp ?	brennie	April 18, 2015, 10:16 p.m.
This method needs a docstring that documents what update_counts and old_reviewed do. Also, old_reviewed needs a better name. Perhaps something …	brennie	April 18, 2015, 10:16 p.m.
ocstrings should be of the following format: """Single line summary. Multi-line description. """	brennie	April 19, 2015, 5:57 a.m.
Blank line between statement and block.	brennie	April 18, 2015, 10:17 p.m.
Can we format this as: elif (self.last_review_activity_timestamp is not None and old_reviews is not None):	brennie	April 18, 2015, 10:17 p.m.
This method needs a docstring. It should also probably be pseudo-private (i.e., it should have a leading underscore).	brennie	April 18, 2015, 10:17 p.m.
Can we do this as: LocalSiteProfile.objects.filter(local_site=self.local_site, Q(user__review_groups__in=groups) \| Q(user__in=people)) Also, can we pull out this query set as a variable …	brennie	April 18, 2015, 10:19 p.m.
Docstrings should be wrapped at 80. The summary should be short and sweet. How about something like: """Decrease the count …	brennie	April 19, 2015, 5:57 a.m.
Since we re-use this all over the place, maybe this should be refactored into a nice little helper method? Otherwise …	brennie	April 18, 2015, 10:17 p.m.
See previous comment.	brennie	April 18, 2015, 10:17 p.m.
Col: 80 E501 line too long (111 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (111 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 19 W503 line break before binary operator	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 19 W503 line break before binary operator	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (112 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	April 18, 2015, 10:26 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	April 18, 2015, 10:35 p.m.
Col: 27 E127 continuation line over-indented for visual indent	reviewbot	April 18, 2015, 10:35 p.m.
Col: 27 E127 continuation line over-indented for visual indent	reviewbot	April 18, 2015, 10:35 p.m.
This docstring doesn't actually explain what the function does.	brennie	April 23, 2015, 3:45 a.m.
Needs a docstring.	brennie	April 23, 2015, 3:45 a.m.
Blank line between these.	brennie	April 23, 2015, 3:45 a.m.
Need a docstring	brennie	April 23, 2015, 3:45 a.m.
Leftover from debugging?	brennie	April 23, 2015, 3:45 a.m.
Blank line between a block and a statement.	brennie	April 23, 2015, 3:45 a.m.
redefinition of unused 'LocalSiteProfile' from line 12	reviewbot	April 19, 2015, 6:03 a.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	April 19, 2015, 6:03 a.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	April 19, 2015, 6:03 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 19, 2015, 8:28 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 19, 2015, 8:30 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 19, 2015, 8:30 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/grids.py
    reviewboard/accounts/admin.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/grids.py
    reviewboard/accounts/admin.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js

reviewboard/accounts/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/accounts/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/datagrids/builtin_items.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/datagrids/builtin_items.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 71
 W291 trailing whitespace
```
reviewboard/datagrids/builtin_items.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

Change Summary:

add function to filter the unreviewed review requests

Commit:

-	6e648650a1bb7454d9f9f1b076cf084f17819dba
+	f556be699d755406b70116e2990e52cf776bb6be

Diff:

Revision 2 (+50 -5)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/views/reviewBoxListView.js

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js

reviewboard/datagrids/builtin_items.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 71
 W291 trailing whitespace
```
reviewboard/datagrids/builtin_items.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/datagrids/grids.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 39
 E231 missing whitespace after ','
```
reviewboard/datagrids/grids.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 39
 E231 missing whitespace after ','
```
reviewboard/reviews/managers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 5
 E265 block comment should start with '# '
```
reviewboard/reviews/managers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
reviewboard/reviews/managers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```

Change Summary:

small format modification

Commit:

-	f556be699d755406b70116e2990e52cf776bb6be
+	7bb0609fde29dae1bef00171bedd54af3456d162

Diff:

Revision 3 (+50 -5)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/views/reviewBoxListView.js

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js

reviewboard/datagrids/builtin_items.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/datagrids/grids.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 39
 E231 missing whitespace after ','
```
reviewboard/reviews/managers.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```

Change Summary:

finish the outgoing unreviewed function, lack of enough tests, will cover the tests in the future.

Commit:

-	7bb0609fde29dae1bef00171bedd54af3456d162
+	8400939d9b6ff917b47877d783499805c8a110f8

Diff:

Revision 4 (+72 -16)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js

reviewboard/datagrids/grids.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 39
 E231 missing whitespace after ','
```
reviewboard/reviews/managers.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 52
 E711 comparison to None should be 'if cond is None:'
```
reviewboard/reviews/models/review_request.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 56
 E711 comparison to None should be 'if cond is None:'
```
reviewboard/reviews/models/review_request.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 56
 E711 comparison to None should be 'if cond is not None:'
```
reviewboard/reviews/models/review_request.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```

Change Summary:

fix some format issues

Commit:

-	8400939d9b6ff917b47877d783499805c8a110f8
+	80f3a9958e6d5855f0cbfbbf4439a5d9afc4934c

Diff:

Revision 5 (+74 -16)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js

Change Summary:

delete some unneccessary codes

Commit:

-	80f3a9958e6d5855f0cbfbbf4439a5d9afc4934c
+	d82df8b2d01ac453cd2ff4aa664f80e303775dd1

Diff:

Revision 6 (+71 -17)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxListView.js

reviewboard/accounts/models.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Use single quotes for strings.
```

reviewboard/datagrids/builtin_items.py (Diff revision 6)

The issue has been resolved. Show all issues

three links?

Also this should be formatted as "All", "Open", and "Unreviewed"

seanchain April 13, 2015, 10:04 p.m.

Yes, the unreviewed link is what I am working on

reviewboard/datagrids/builtin_items.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/datagrids/builtin_items.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/datagrids/builtin_items.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/reviews/managers.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/managers.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```

reviewboard/reviews/managers.py (Diff revision 6)

The issue has been resolved. Show all issues

This doesn't handle the case where status is S or D so this may cause a regression.

seanchain April 13, 2015, 10:04 p.m.

But we don't need a section to display the discarded or submitted review requests, do we?

brennie April 14, 2015, 1:25 a.m.

I feel like using an "psuedo" status is a bad idea here. I think it would be better if we have the _query parameter two extra boolean arguments: incoming_unreviewed and outgoing_unreviewed (or similar) and then use those instead of changing the meaning of status.

chipx86 April 14, 2015, 1:34 a.m.

Yeah, pseudo states are going to get us into some trouble, I fear. That's a pretty core thing. Introducing new possible values for status opens up significant API compatibility and security concerns we'd need to thoroughly test. Plus, there are lots of situations where we do a query for review requests that goes beyond what's default in public(), without having to modify public() itself.

The Dashboard is the place that needs to deal with these sort of queries, so I'd suggest just having the filter in there. You should be able to do a standard ReviewRequest.objects.public(...).filter(last_review_activity_timestamp=None) without any problems.

reviewboard/reviews/models/review.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/models/review.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Left over from debugging?
```
reviewboard/reviews/models/review.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/models/review.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```

reviewboard/reviews/models/review_request.py (Diff revision 6)

The issue has been resolved. Show all issues

I don't feel like these are states for a review request. Wouldn't a review request be unreviewed and incoming for a reviewer but unreviewed and outgoing for its submitter?

seanchain April 13, 2015, 10:04 p.m.

yes, these statuses are not neccessary, and I will delete these.

reviewboard/reviews/models/review_request.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/models/review_request.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/models/review_request.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Blank line between two blocks.
```
reviewboard/reviews/models/review_request.py (Diff revision 6)
The issue has been resolved. Show all issues
```
No blank line here.
```

reviewboard/reviews/models/review_request.py (Diff revision 6)

The issue has been resolved. Show all issues

Can you format this like so:

elif (self.last_review_request_activity_timetamp is not None and
       old_reviews is None):
    site_profile.decrement_unreviewed_outgoing_request_count()

reviewboard/static/rb/js/views/reviewBoxListView.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```

Change Summary:

fix some issues

Commit:

-	d82df8b2d01ac453cd2ff4aa664f80e303775dd1
+	c3f73e24ca6decb123a44e43c6763cb2f6ea7f73

Diff:

Revision 7 (+62 -15)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/reviews/models/review_request.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Col: 29
 E127 continuation line over-indented for visual indent
```

Change Summary:

fix some issues

Commit:

-	c3f73e24ca6decb123a44e43c6763cb2f6ea7f73
+	acd8c3e09a2fce9b79ad9c741a9eea0f6c6191ef

Diff:

Revision 8 (+61 -10)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/accounts/models.py (Diff revision 8)

The issue has been resolved. Show all issues

I don't think this filtering is going to work the way you want it to work.

We really can't add the I/O states to a review request because they are per-user things and the review request status is not a per-user thing. We can't filter on status='O' or status='I' here.

You're probably going to want to use a regular queryset object here, like so:

initializer=lambda p: ReviewRequest.objects.filter(submitter=p.user, status='P', last_review_activity_timestamp=None).count()

or something similar. You may want to refactor this into a method on the ReviewRequestManager class.

seanchain April 14, 2015, 7:44 a.m.

Yes, I know this place is not going to work, and it is just some of my attemps and failed, but I forgot to remove the codes, really sorry about this and I think I will just delete these codes and try some another methods then.

reviewboard/datagrids/grids.py (Diff revision 8)

The issue has been resolved. Show all issues

See my above comment about why this isn't going to work.

seanchain April 14, 2015, 7:44 a.m.

the codes here I think is going to work because I add the filter to the function from_user and It really filter the unreviewed review requests

reviewboard/reviews/models/review_request.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Undo this change.
```

Change Summary:

fix some issues

Commit:

-	acd8c3e09a2fce9b79ad9c741a9eea0f6c6191ef
+	63a353c4827ccf60c29a876eb93fba7b6dbe97c3

Diff:

Revision 9 (+49 -9)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/reviews/models/review.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py



Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/reviews/models/review.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py

Change Summary:

add a new parameter to pass the unreviewed status instead of using the default status value

Commit:

-	63a353c4827ccf60c29a876eb93fba7b6dbe97c3
+	fab5bd97d358030ba5458e269022ae9f53e212db

Diff:

Revision 10 (+62 -10)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/accounts/models.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
reviewboard/accounts/models.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
reviewboard/reviews/managers.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 5
 E301 expected 1 blank line, found 0
```
reviewboard/reviews/managers.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (86 > 79 characters)
```

Change Summary:

fix some issues

Commit:

-	fab5bd97d358030ba5458e269022ae9f53e212db
+	4576ea423184d2517c551a2884fe1e5f8490d2fe

Diff:

Revision 11 (+67 -13)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/reviews/managers.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 5
 E301 expected 1 blank line, found 0
```
reviewboard/reviews/managers.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 33
 E231 missing whitespace after ','
```

Change Summary:

add the incoming review filter to make the unreviewed incoming count right.

Commit:

-	4576ea423184d2517c551a2884fe1e5f8490d2fe
+	287e76bebb0fed95dc48f37c2add6ddc9a91c1c2

Diff:

Revision 12 (+92 -13)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/reviews/managers.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Change Summary:

fix issues

Diff:

Revision 13 (+92 -13)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/reviews/managers.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Commit:

-	287e76bebb0fed95dc48f37c2add6ddc9a91c1c2
+	e10f1b8365bd60f288f4e9faedf6c6264fa2c254

Diff:

Revision 14 (+91 -12)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/accounts/models.py (Diff revision 14)
The issue has been resolved. Show all issues
```
This should use a named constant.
```
reviewboard/accounts/models.py (Diff revision 14)
The issue has been resolved. Show all issues
```
This should use a named constant.
```
reviewboard/reviews/managers.py (Diff revision 14)
The issue has been resolved. Show all issues
```
This should do Q(status=status).
```
reviewboard/reviews/managers.py (Diff revision 14)
The issue has been resolved. Show all issues
```
We should be using named constants for these.
```

reviewboard/reviews/managers.py (Diff revision 14)

The issue has been resolved. Show all issues

This should do Q(status=status).
Also can we format this as:

query = (query &
         Q(status=status) &
         Q(last_review_activity_timestamp=None))

reviewboard/reviews/models/review.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Can we call this last_review or last_review_timestamp ?
```

reviewboard/reviews/models/review_request.py (Diff revision 14)

The issue has been resolved. Show all issues

This method needs a docstring that documents what update_counts and old_reviewed do.

Also, old_reviewed needs a better name. Perhaps something like last_review_timestamp ?

reviewboard/reviews/models/review_request.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Blank line between statement and block.
```

reviewboard/reviews/models/review_request.py (Diff revision 14)

The issue has been resolved. Show all issues

Can we format this as:

elif (self.last_review_activity_timestamp is not None and
      old_reviews is not None):

reviewboard/reviews/models/review_request.py (Diff revision 14)

The issue has been resolved. Show all issues

This method needs a docstring. It should also probably be pseudo-private (i.e., it should have a leading underscore).

reviewboard/reviews/models/review_request.py (Diff revision 14)

The issue has been resolved. Show all issues

Can we do this as:

LocalSiteProfile.objects.filter(local_site=self.local_site,
                                Q(user__review_groups__in=groups) | Q(user__in=people))


Also, can we pull out this query set as a variable and pass that along to the decrement function?

reviewboard/reviews/models/review_request.py (Diff revision 14)

The issue has been resolved. Show all issues

Since we re-use this all over the place, maybe this should be refactored into a nice little helper method?

Otherwise see other comment about formatting.

reviewboard/reviews/models/review_request.py (Diff revision 14)
The issue has been resolved. Show all issues
```
See previous comment.
```

Change Summary:

fix some issues

Commit:

-	e10f1b8365bd60f288f4e9faedf6c6264fa2c254
+	7869a59cb649a22b4beb20aa4fdd5c5defc000c9

Diff:

Revision 15 (+108 -21)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/datagrids/grids.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (111 > 79 characters)
```
reviewboard/datagrids/grids.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (111 > 79 characters)
```
reviewboard/reviews/managers.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 19
 W503 line break before binary operator
```
reviewboard/reviews/managers.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/reviews/models/review.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 19
 W503 line break before binary operator
```
reviewboard/reviews/models/review_request.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (112 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```

Change Summary:

fix some issues

Commit:

-	7869a59cb649a22b4beb20aa4fdd5c5defc000c9
+	a8c17caf65582fc709504cba126253818063bed2

Diff:

Revision 16 (+118 -21)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/reviews/managers.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
reviewboard/reviews/managers.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 27
 E127 continuation line over-indented for visual indent
```
reviewboard/reviews/models/review_request.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 27
 E127 continuation line over-indented for visual indent
```

Change Summary:

fix some issues

Commit:

-	a8c17caf65582fc709504cba126253818063bed2
+	30f0418ee48a861417c47e062eaf964d42b6b228

Diff:

Revision 17 (+118 -21)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/accounts/models.py (Diff revisions 14 - 17)
The issue has been resolved. Show all issues
```
Single quotes for these.
```

reviewboard/accounts/models.py (Diff revisions 14 - 17)

The issue has been resolved. Show all issues

These really aren't needed. We only use things like this for enumerated char fields in the database.

reviewboard/datagrids/grids.py (Diff revisions 14 - 17)

The issue has been resolved. Show all issues

Any particular reason not to import this at the top of the file?
If there is a good reason, this should be at the top of the method.

reviewboard/reviews/managers.py (Diff revisions 14 - 15)
The issue has been resolved. Show all issues
```
Undo this change.
```

reviewboard/reviews/managers.py (Diff revisions 14 - 15)

The issue has been resolved. Show all issues

This logic can be simplified quite a bit. We are doing query = query & other_query in each case, which can replaced with query &= other_query. We also use query = query & Q(status=status) in both cases, so that can be factored out as follows:

    if status:
        query &= Q(status=status)

        if (unreviwed_status in (LocalSiteProfile.OUTGOING_UNREVIEWED,
                                 LocalSiteProfile.INCOMING_UNREVIEWED):
            query &= Q(last_review_activity_timestamp=None)

reviewboard/reviews/models/review_request.py (Diff revisions 14 - 15)

The issue has been resolved. Show all issues

ocstrings should be of the following format:

"""Single line summary.

Multi-line description.
"""

reviewboard/reviews/models/review_request.py (Diff revisions 14 - 15)

The issue has been resolved. Show all issues

Docstrings should be wrapped at 80.

The summary should be short and sweet. How about something like:

        """Decrease the count of unreviewed incoming requests.

        The count is only decreased if a review request that was previously
        unreviewed has become reviewed.
        """

Change Summary:

fix a count bug and some issues

Commit:

-	30f0418ee48a861417c47e062eaf964d42b6b228
+	9931b170531f4825cc0d1b07ef35b9b092309fed

Diff:

Revision 18 (+119 -24)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/datagrids/grids.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 redefinition of unused 'LocalSiteProfile' from line 12
```
reviewboard/reviews/models/review_request.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/models/review_request.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

Change Summary:

fix a bug about counting and some issues.

Commit:

-	9931b170531f4825cc0d1b07ef35b9b092309fed
+	f9a6fc0fb6eae5769da0178e897ff8dc0c40c1aa

Diff:

Revision 19 (+121 -24)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/reviews/models/review_request.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

Commit:

-	f9a6fc0fb6eae5769da0178e897ff8dc0c40c1aa
+	479706c0a82111eb3ef1782a25a2604c6899900b

Diff:

Revision 20 (+122 -24)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

reviewboard/reviews/models/review_request.py (Diff revisions 17 - 18)
The issue has been resolved. Show all issues
```
This docstring doesn't actually explain what the function does.
```
reviewboard/reviews/models/review_request.py (Diff revisions 17 - 18)
The issue has been resolved. Show all issues
```
Needs a docstring.
```
reviewboard/reviews/models/review_request.py (Diff revisions 17 - 18)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/reviews/models/review_request.py (Diff revisions 17 - 18)
The issue has been resolved. Show all issues
```
Need a docstring
```
reviewboard/reviews/models/review_request.py (Diff revisions 17 - 18)
The issue has been resolved. Show all issues
```
Leftover from debugging?
```
reviewboard/reviews/models/review_request.py (Diff revisions 17 - 18)
The issue has been resolved. Show all issues
```
Blank line between a block and a statement.
```

Change Summary:

fix some issues.

Commit:

-	479706c0a82111eb3ef1782a25a2604c6899900b
+	db813c313dac7252bf2cb060807f597e92da4fb8

Diff:

Revision 21 (+129 -24)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/datagrids/builtin_items.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/views.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/views.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/builtin_items.py
    reviewboard/accounts/models.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/admin.py
    reviewboard/reviews/models/review.py

[WIP] Add the unreviewed section in my dashboard

Information

Reviewers

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Diff:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Status: Discarded