-
-
-
-
-
-
reviewboard/datagrids/builtin_items.py (Diff revision 1) Col: 80 E501 line too long (82 > 79 characters)
[WIP] Add the unreviewed section in my dashboard
Review Request #7193 — Created April 11, 2015 and discarded
Information | |
---|---|
seanchain | |
Review Board | |
master | |
Reviewers | |
reviewboard, students | |
Done some front-end work to add the two section to the dashboard, so far functionless, only on the web page.
Description | From | Last Updated |
---|---|---|
Col: 1 W293 blank line contains whitespace |
![]() |
|
Col: 1 W293 blank line contains whitespace |
![]() |
|
Col: 1 W293 blank line contains whitespace |
![]() |
|
Col: 71 W291 trailing whitespace |
![]() |
|
Col: 80 E501 line too long (82 > 79 characters) |
![]() |
|
Col: 71 W291 trailing whitespace |
![]() |
|
Col: 80 E501 line too long (82 > 79 characters) |
![]() |
|
Col: 39 E231 missing whitespace after ',' |
![]() |
|
Col: 39 E231 missing whitespace after ',' |
![]() |
|
Col: 5 E265 block comment should start with '# ' |
![]() |
|
Col: 80 E501 line too long (89 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (88 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (82 > 79 characters) |
![]() |
|
Col: 39 E231 missing whitespace after ',' |
![]() |
|
Col: 80 E501 line too long (88 > 79 characters) |
![]() |
|
Col: 39 E231 missing whitespace after ',' |
![]() |
|
Col: 80 E501 line too long (88 > 79 characters) |
![]() |
|
Col: 52 E711 comparison to None should be 'if cond is None:' |
![]() |
|
Col: 56 E711 comparison to None should be 'if cond is None:' |
![]() |
|
Col: 56 E711 comparison to None should be 'if cond is not None:' |
![]() |
|
Col: 80 E501 line too long (87 > 79 characters) |
![]() |
|
Use single quotes for strings. |
|
|
three links? Also this should be formatted as "All", "Open", and "Unreviewed" |
|
|
Blank line between these. |
|
|
Blank line between these. |
|
|
Blank line between these. |
|
|
Undo this change. |
|
|
Undo this change. |
|
|
This doesn't handle the case where status is S or D so this may cause a regression. |
|
|
Undo this change. |
|
|
Left over from debugging? |
|
|
Undo this change. |
|
|
Undo this change. |
|
|
I don't feel like these are states for a review request. Wouldn't a review request be unreviewed and incoming for … |
|
|
Undo this change. |
|
|
Undo this change. |
|
|
Blank line between two blocks. |
|
|
No blank line here. |
|
|
Can you format this like so: elif (self.last_review_request_activity_timetamp is not None and old_reviews is None): site_profile.decrement_unreviewed_outgoing_request_count() |
|
|
Undo this change. |
|
|
Col: 29 E127 continuation line over-indented for visual indent |
![]() |
|
I don't think this filtering is going to work the way you want it to work. We really can't add … |
|
|
See my above comment about why this isn't going to work. |
|
|
Undo this change. |
|
|
Col: 80 E501 line too long (87 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (87 > 79 characters) |
![]() |
|
Col: 5 E301 expected 1 blank line, found 0 |
![]() |
|
Col: 80 E501 line too long (86 > 79 characters) |
![]() |
|
Col: 5 E301 expected 1 blank line, found 0 |
![]() |
|
Col: 33 E231 missing whitespace after ',' |
![]() |
|
Col: 1 W293 blank line contains whitespace |
![]() |
|
Col: 1 W293 blank line contains whitespace |
![]() |
|
Single quotes for these. |
|
|
These really aren't needed. We only use things like this for enumerated char fields in the database. |
|
|
This should use a named constant. |
|
|
This should use a named constant. |
|
|
Any particular reason not to import this at the top of the file? If there is a good reason, this … |
|
|
Undo this change. |
|
|
This logic can be simplified quite a bit. We are doing query = query & other_query in each case, which … |
|
|
This should do Q(status=status). |
|
|
We should be using named constants for these. |
|
|
This should do Q(status=status). Also can we format this as: query = (query & Q(status=status) & Q(last_review_activity_timestamp=None)) |
|
|
Can we call this last_review or last_review_timestamp ? |
|
|
This method needs a docstring that documents what update_counts and old_reviewed do. Also, old_reviewed needs a better name. Perhaps something … |
|
|
ocstrings should be of the following format: """Single line summary. Multi-line description. """ |
|
|
Blank line between statement and block. |
|
|
Can we format this as: elif (self.last_review_activity_timestamp is not None and old_reviews is not None): |
|
|
This method needs a docstring. It should also probably be pseudo-private (i.e., it should have a leading underscore). |
|
|
Can we do this as: LocalSiteProfile.objects.filter(local_site=self.local_site, Q(user__review_groups__in=groups) | Q(user__in=people)) Also, can we pull out this query set as a variable … |
|
|
Docstrings should be wrapped at 80. The summary should be short and sweet. How about something like: """Decrease the count … |
|
|
Since we re-use this all over the place, maybe this should be refactored into a nice little helper method? Otherwise … |
|
|
See previous comment. |
|
|
Col: 80 E501 line too long (111 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (111 > 79 characters) |
![]() |
|
Col: 19 W503 line break before binary operator |
![]() |
|
Col: 80 E501 line too long (80 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (87 > 79 characters) |
![]() |
|
Col: 19 W503 line break before binary operator |
![]() |
|
Col: 80 E501 line too long (112 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (92 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (92 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (92 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (92 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (92 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (85 > 79 characters) |
![]() |
|
Col: 27 E127 continuation line over-indented for visual indent |
![]() |
|
Col: 27 E127 continuation line over-indented for visual indent |
![]() |
|
This docstring doesn't actually explain what the function does. |
|
|
Needs a docstring. |
|
|
Blank line between these. |
|
|
Need a docstring |
|
|
Leftover from debugging? |
|
|
Blank line between a block and a statement. |
|
|
redefinition of unused 'LocalSiteProfile' from line 12 |
![]() |
|
Col: 80 E501 line too long (84 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (84 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (83 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (83 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (83 > 79 characters) |
![]() |

Change Summary:
add function to filter the unreviewed review requests
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+50 -5) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js
-
-
reviewboard/datagrids/builtin_items.py (Diff revision 2) Col: 80 E501 line too long (82 > 79 characters)
-
-
-
-
-
Change Summary:
small format modification
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+50 -5) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js
-
reviewboard/datagrids/builtin_items.py (Diff revision 3) Col: 80 E501 line too long (82 > 79 characters)
-
-
Change Summary:
finish the outgoing unreviewed function, lack of enough tests, will cover the tests in the future.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+72 -16) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js
-
-
-
reviewboard/reviews/models/review_request.py (Diff revision 4) Col: 52 E711 comparison to None should be 'if cond is None:'
-
reviewboard/reviews/models/review_request.py (Diff revision 4) Col: 56 E711 comparison to None should be 'if cond is None:'
-
reviewboard/reviews/models/review_request.py (Diff revision 4) Col: 56 E711 comparison to None should be 'if cond is not None:'
-
reviewboard/reviews/models/review_request.py (Diff revision 4) Col: 80 E501 line too long (87 > 79 characters)
Change Summary:
fix some format issues
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+74 -16) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js
Change Summary:
delete some unneccessary codes
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+71 -17) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxListView.js
-
-
-
reviewboard/datagrids/builtin_items.py (Diff revision 6) three links?
Also this should be formatted as
"All", "Open", and "Unreviewed"
-
-
-
-
-
-
reviewboard/reviews/managers.py (Diff revision 6) This doesn't handle the case where
status
isS
orD
so this may cause a regression. -
-
-
-
-
reviewboard/reviews/models/review_request.py (Diff revision 6) I don't feel like these are states for a review request. Wouldn't a review request be unreviewed and incoming for a reviewer but unreviewed and outgoing for its submitter?
-
-
-
-
-
reviewboard/reviews/models/review_request.py (Diff revision 6) Can you format this like so:
elif (self.last_review_request_activity_timetamp is not None and old_reviews is None): site_profile.decrement_unreviewed_outgoing_request_count()
-
Change Summary:
fix some issues
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+62 -15) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
reviewboard/reviews/models/review_request.py (Diff revision 7) Col: 29 E127 continuation line over-indented for visual indent
Change Summary:
fix some issues
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 8 (+61 -10) |

-
Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
-
reviewboard/accounts/models.py (Diff revision 8) I don't think this filtering is going to work the way you want it to work.
We really can't add the I/O states to a review request because they are per-user things and the review request status is not a per-user thing. We can't filter on
status='O'
orstatus='I'
here.You're probably going to want to use a regular queryset object here, like so:
initializer=lambda p: ReviewRequest.objects.filter(submitter=p.user, status='P', last_review_activity_timestamp=None).count()
or something similar. You may want to refactor this into a method on the
ReviewRequestManager
class. -
reviewboard/datagrids/grids.py (Diff revision 8) See my above comment about why this isn't going to work.
-
Change Summary:
fix some issues
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 9 (+49 -9) |

-
Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/reviews/models/review.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/reviews/models/review.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py
Change Summary:
add a new parameter to pass the unreviewed status instead of using the default status value
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 10 (+62 -10) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
-
-
-
Change Summary:
fix some issues
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 11 (+67 -13) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
-
Change Summary:
add the incoming review filter to make the unreviewed incoming count right.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 12 (+92 -13) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 14 (+91 -12) |

-
Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
-
-
-
-
-
reviewboard/reviews/managers.py (Diff revision 14) This should do
Q(status=status)
.Also can we format this as:
query = (query & Q(status=status) & Q(last_review_activity_timestamp=None))
-
reviewboard/reviews/models/review.py (Diff revision 14) Can we call this
last_review
orlast_review_timestamp
? -
reviewboard/reviews/models/review_request.py (Diff revision 14) This method needs a docstring that documents what
update_counts
andold_reviewed
do.Also,
old_reviewed
needs a better name. Perhaps something likelast_review_timestamp
? -
reviewboard/reviews/models/review_request.py (Diff revision 14) Blank line between statement and block.
-
reviewboard/reviews/models/review_request.py (Diff revision 14) Can we format this as:
elif (self.last_review_activity_timestamp is not None and old_reviews is not None):
-
reviewboard/reviews/models/review_request.py (Diff revision 14) This method needs a docstring. It should also probably be pseudo-private (i.e., it should have a leading underscore).
-
reviewboard/reviews/models/review_request.py (Diff revision 14) Can we do this as:
LocalSiteProfile.objects.filter(local_site=self.local_site, Q(user__review_groups__in=groups) | Q(user__in=people))
Also, can we pull out this query set as a variable and pass that along to the
decrement
function? -
reviewboard/reviews/models/review_request.py (Diff revision 14) Since we re-use this all over the place, maybe this should be refactored into a nice little helper method?
Otherwise see other comment about formatting.
-
Change Summary:
fix some issues
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 15 (+108 -21) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
-
-
-
-
reviewboard/reviews/models/review.py (Diff revision 15) Col: 80 E501 line too long (87 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 15) Col: 19 W503 line break before binary operator
-
reviewboard/reviews/models/review_request.py (Diff revision 15) Col: 80 E501 line too long (112 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 15) Col: 80 E501 line too long (92 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 15) Col: 80 E501 line too long (92 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 15) Col: 80 E501 line too long (92 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 15) Col: 80 E501 line too long (92 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 15) Col: 80 E501 line too long (92 > 79 characters)
Change Summary:
fix some issues
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 16 (+118 -21) |

-
Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
-
reviewboard/reviews/managers.py (Diff revision 16) Col: 27 E127 continuation line over-indented for visual indent
-
reviewboard/reviews/models/review_request.py (Diff revision 16) Col: 27 E127 continuation line over-indented for visual indent
Change Summary:
fix some issues
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 17 (+118 -21) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
-
-
reviewboard/accounts/models.py (Diff revisions 14 - 17) These really aren't needed. We only use things like this for enumerated char fields in the database.
-
reviewboard/datagrids/grids.py (Diff revisions 14 - 17) Any particular reason not to import this at the top of the file?
If there is a good reason, this should be at the top of the method.
-
-
reviewboard/reviews/managers.py (Diff revisions 14 - 15) This logic can be simplified quite a bit. We are doing
query = query & other_query
in each case, which can replaced withquery &= other_query
. We also usequery = query & Q(status=status)
in both cases, so that can be factored out as follows:if status: query &= Q(status=status) if (unreviwed_status in (LocalSiteProfile.OUTGOING_UNREVIEWED, LocalSiteProfile.INCOMING_UNREVIEWED): query &= Q(last_review_activity_timestamp=None)
-
reviewboard/reviews/models/review_request.py (Diff revisions 14 - 15) ocstrings should be of the following format:
"""Single line summary.
Multi-line description.
""" -
reviewboard/reviews/models/review_request.py (Diff revisions 14 - 15) Docstrings should be wrapped at 80.
The summary should be short and sweet. How about something like:
"""Decrease the count of unreviewed incoming requests. The count is only decreased if a review request that was previously unreviewed has become reviewed. """
Change Summary:
fix a count bug and some issues
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 18 (+119 -24) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
reviewboard/datagrids/grids.py (Diff revision 18) redefinition of unused 'LocalSiteProfile' from line 12
-
reviewboard/reviews/models/review_request.py (Diff revision 18) Col: 80 E501 line too long (84 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 18) Col: 80 E501 line too long (84 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 18) Col: 80 E501 line too long (83 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 18) Col: 80 E501 line too long (83 > 79 characters)
Change Summary:
fix a bug about counting and some issues.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 19 (+121 -24) |

-
Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
reviewboard/reviews/models/review_request.py (Diff revision 19) Col: 80 E501 line too long (83 > 79 characters)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 20 (+122 -24) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py
-
-
reviewboard/reviews/models/review_request.py (Diff revisions 17 - 18) This docstring doesn't actually explain what the function does.
-
-
-
-
-
reviewboard/reviews/models/review_request.py (Diff revisions 17 - 18) Blank line between a block and a statement.
Change Summary:
fix some issues.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 21 (+129 -24) |

-
Tool: Pyflakes Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/views.py reviewboard/reviews/models/review_request.py reviewboard/datagrids/grids.py reviewboard/datagrids/builtin_items.py reviewboard/accounts/models.py reviewboard/reviews/managers.py reviewboard/accounts/admin.py reviewboard/reviews/models/review.py