Add button to list all entries in an AlphanumericDataGrid.
Review Request #7190 — Created April 10, 2015 and submitted
Added "All" button to list all entries in an AlphanumericDataGrid. This can be useful to list e.g. all users in a review group, or all users on the Review Board server, especially for servers/groups with few users.
- Tested that alphanumeric buttons work as before
- Tested that "All" button shows all users, and that they are sortable
- Tested that "All" is the default page
| Description | From | Last Updated |
|---|---|---|
|
Perhaps we should default to all? |
 david
|
|
|
Hmm. I'm not sure how to localize this. I'm thinking that we probably want to have some specialized code in … |
david
|
|
|
Can this be formatted as follows to remove the backslash? self.extra_context['letters'] = (['all', '0'] + list(string.ascii_uppercase)) |
 brennie
|
|
|
Should be {{letter}} not {{ letter }}. |
brennie
|
|
|
Should be {{letter}} not {{ letter }. |
brennie
|
-
-
-
djblets/datagrid/grids.py (Diff revision 1) Hmm. I'm not sure how to localize this. I'm thinking that we probably want to have some specialized code in the paginator template that adds this, rather than including it in the
lettersvariable in the context. We can then have the value passed in in the query string be different from what's presented on the screen.
HA
Change Summary:
Let 'All' be default page, add translation of 'All'.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+9 -7) |
-
Tool: Pyflakes Processed Files: djblets/datagrid/grids.py Ignored Files: djblets/datagrid/templates/datagrid/alphanumeric_paginator.html Tool: PEP8 Style Checker Processed Files: djblets/datagrid/grids.py Ignored Files: djblets/datagrid/templates/datagrid/alphanumeric_paginator.html
-
Just a few minor fixes, and then I say ship it!
Looks good to me.
-
djblets/datagrid/grids.py (Diff revision 2) Can this be formatted as follows to remove the backslash?
self.extra_context['letters'] = (['all', '0'] + list(string.ascii_uppercase)) -
djblets/datagrid/templates/datagrid/alphanumeric_paginator.html (Diff revision 2) Should be
{{letter}}not{{ letter }}. -
djblets/datagrid/templates/datagrid/alphanumeric_paginator.html (Diff revision 2) Should be
{{letter}}not{{ letter }.
HA
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+9 -7) |
Tool: Pyflakes Processed Files: djblets/datagrid/grids.py Ignored Files: djblets/datagrid/templates/datagrid/alphanumeric_paginator.html Tool: PEP8 Style Checker Processed Files: djblets/datagrid/grids.py Ignored Files: djblets/datagrid/templates/datagrid/alphanumeric_paginator.html