Summary:

[checklist] Refactoring of checklist

Review Request #7176 — Created April 7, 2015 and submitted May 7, 2015, 5:01 a.m.

Information
Owner:	Sunxperous
Repository:	rb-extension-pack
Branch:
Bugs:
Depends On:	~~7099~~
Blocks:	7248
Commit:	2124492...
Reviewers
Groups:	rb-extension-pack, students
People:

Description

Refactoring includes

Use of request.user instead of passing user_id in every HTTP request
Updating of the view only after successful API response
Renamed status of each item from finished to checked
Use of ChecklistItem non-database resource API instead of using HTTP request parameters
Moving of front-end API logic from view to model
CSS hyphens everywhere instead of underscores
Improving Python code (renaming variables, removing redundant code)
Start checklist item IDs from 0 instead of 1.

Testing Done

Basic CRUD functionality remains. Ensured that the views will not update unless there is a successful response from the server.

Issues

Description	From	Last Updated
'resources' imported but unused	reviewbot	April 8, 2015, 10:06 p.m.
Col: 25 E261 at least two spaces before inline comment	reviewbot	April 8, 2015, 10:06 p.m.
local variable 'item' is assigned to but never used	reviewbot	April 8, 2015, 10:06 p.m.
'webapi_response_errors' imported but unused	reviewbot	April 8, 2015, 10:06 p.m.
'ChecklistItem' imported but unused	reviewbot	April 8, 2015, 10:06 p.m.
Col: 53 E261 at least two spaces before inline comment	reviewbot	April 8, 2015, 10:06 p.m.
The first line of this file should be: from __future__ import unicode_literals	brennie	April 12, 2015, 9:40 a.m.
Can you put these into alphabetical order?	brennie	April 12, 2015, 9:40 a.m.
Undo this change.	brennie	April 12, 2015, 9:41 a.m.
The first line of this file should be: from __future__ import unicode_literals	brennie	April 12, 2015, 9:41 a.m.
Undo this change. django, djblets, and reviewboard are all third party imports with repsect to rb-extension-pack.	brennie	April 12, 2015, 9:41 a.m.
Docstrings should be of the following form: """Single line summary Multi-line description. """	brennie	April 12, 2015, 9:42 a.m.
If we're going to put a code example in the docstring, we should be using a restructured text code block.	brennie	April 23, 2015, 9:36 a.m.
"A JSON blob"	brennie	April 12, 2015, 9:42 a.m.
This should probably be six.text_type (from django.utils.six), not str. If this should be a byte string type, use six.binary_type instead.	brennie	April 23, 2015, 9:36 a.m.
Same comment about six.text_type vs str applies here.	brennie	April 23, 2015, 9:36 a.m.
You don't need pass if the class has a docstring.	brennie	April 12, 2015, 10:02 a.m.
Same comment here about unicode_literals.	brennie	April 12, 2015, 9:42 a.m.
Same comment about unicode_literals as above.	brennie	April 12, 2015, 9:43 a.m.
Blank line between these.	brennie	April 12, 2015, 10:02 a.m.
Shouldn't this be int ? The model indicates that ids are integers.	brennie	April 23, 2015, 9:37 a.m.
Missing trailing comma.	brennie	April 12, 2015, 9:43 a.m.
This should be six.text_type.	brennie	April 23, 2015, 9:37 a.m.
Missing trailing comma.	brennie	April 12, 2015, 9:43 a.m.
Missing trailing comma.	brennie	April 12, 2015, 9:43 a.m.
Missing trailing comma.	brennie	April 12, 2015, 9:43 a.m.
Can you catch CheckListItem.DoesNotExist here instead?	brennie	April 23, 2015, 9:44 a.m.
six.text_type, not str	brennie	April 23, 2015, 9:44 a.m.
six.text_type	brennie	April 23, 2015, 9:44 a.m.
Can you catch CheckListItem.DoesNotExist here instead?	brennie	April 23, 2015, 9:44 a.m.
six.text_type	brennie	April 23, 2015, 9:44 a.m.
Should have a trailing comma.	brennie	April 12, 2015, 9:44 a.m.
Trailing comma	brennie	April 12, 2015, 9:44 a.m.
Trailing comma.	brennie	April 12, 2015, 9:44 a.m.
Can you catch CheckListItem.DoesNotExist here instead?	brennie	April 23, 2015, 9:44 a.m.
You can add checklist_item_id as a paramter to the function and just refer to it that way. Its cleaner than …	brennie	April 23, 2015, 9:44 a.m.
This shoudl have from __future__ import unicode_literals	brennie	April 12, 2015, 9:44 a.m.
"ID"	brennie	April 12, 2015, 10:04 a.m.
Is this left over from debugging?	brennie	April 23, 2015, 9:45 a.m.
This should be formatted the same as a Python docstring. This applies to all methods.	brennie	April 23, 2015, 9:45 a.m.
Can we just use response.checklist_item.keys() here?	brennie	April 23, 2015, 9:45 a.m.
I feel like since we're using this all over the file, and we always have access to the Checklist object, …	brennie	April 23, 2015, 9:45 a.m.
"The"	brennie	April 12, 2015, 9:47 a.m.
review_request_id shouldn't be quoted.	brennie	April 12, 2015, 9:47 a.m.
How about _addItemToView ?	brennie	April 12, 2015, 9:47 a.m.
I think it would be ok to include the keys we expect in there (id, checked, description ?).	brennie	April 23, 2015, 9:46 p.m.
Won't this start indexing from 1? Shouldn't we index from 0?	brennie	April 23, 2015, 9:46 p.m.
I don't believe you should be using a dummy model for the web API. Models are not required.	brennie	April 23, 2015, 9:46 p.m.
This will end up in public-facing documentation.	brennie	April 23, 2015, 9:46 p.m.
We don't really need this.	brennie	April 23, 2015, 9:46 p.m.
Can we put a doc comment on this?	brennie	April 23, 2015, 9:46 p.m.
Doc comments should be of the form /* * Single line summary. * * Multi-line description. */ Same elsewhere.	brennie	April 23, 2015, 9:46 p.m.
Needs a doc comment.	brennie	April 23, 2015, 9:46 p.m.
Needs long-form doc comment.	brennie	April 23, 2015, 9:46 p.m.
It technically isn't a dictionary -- its a JS object. You could call it a mapping, instead.	brennie	April 23, 2015, 9:46 p.m.
Needs doc comment.	brennie	April 23, 2015, 9:47 p.m.
Needs doc comment.	brennie	April 23, 2015, 9:47 p.m.
Should use long form doc comment. Same elsewhere.	brennie	April 23, 2015, 9:47 p.m.
If you are referring to Python data types, this is actually a six.text_type.	brennie	April 24, 2015, 10:53 p.m.
Same here.	brennie	April 24, 2015, 10:53 p.m.
Can you fix up this docstring?	brennie	April 25, 2015, 12:25 a.m.

Change Summary:

Add comments and documentation. And yay to fixing of the parent-diff bug!

Summary:

-	[WIP] [checklist] Refactoring of checklist
+	[checklist] Refactoring of checklist

Description:

		Refactoring includes

~		Use of `request.user` instead of passing `user.id` in every HTTP request
~		Renamed status of each item from `finished` to `checked`
~		Use of `ChecklistItem` non-database resource instead of based on HTTP request parameters
~		Moving of front-end API logic from view to model
~		CSS hyphens everywhere instead of underscores
~
~		Why is this a [WIP]?
	~	Use of `request.user` instead of passing `user_id` in every HTTP request
	~	Updating of the view only after successful API response
	~	Renamed status of each item from `finished` to `checked`
	~	Use of `ChecklistItem` non-database resource API instead of using HTTP request parameters
	~	Moving of front-end API logic from view to model
	~	CSS hyphens everywhere instead of underscores
	~	Improving Python code (renaming variables, removing redundant code)
-		There's an error when viewing the diff of one the files in this review request.
-		Django back-end code got slightly heavier, so aiming to lighten it a bit before finalizing the change.
-		This may very well not be useful for checklist templates integration, but we'll see.

Testing Done:

~		Basic CRUD functionality remains.
	~	Basic CRUD functionality remains. Ensured that the views will not update unless there is a successful response from the server.

Diff:

Revision 2 (+417 -337)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/models.py
	checklist/checklist/resources/__init__.py
	checklist/checklist/resources/checklist_item.py
	checklist/checklist/resources/checklist_resource.py
	checklist/checklist/static/css/style.less
	checklist/checklist/static/js/models/checklist.js
	checklist/checklist/static/js/models/checklistAPI.js
	2 more

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html



Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html

checklist/checklist/resources/checklist_item.py (Diff revision 2)
Show all issues
```
 'resources' imported but unused
```
checklist/checklist/resources/checklist_item.py (Diff revision 2)
Show all issues
```
Col: 25
 E261 at least two spaces before inline comment
```
checklist/checklist/resources/checklist_item.py (Diff revision 2)
Show all issues
```
 local variable 'item' is assigned to but never used
```
checklist/checklist/resources/checklist_resource.py (Diff revision 2)
Show all issues
```
 'webapi_response_errors' imported but unused
```
checklist/checklist/resources/checklist_resource.py (Diff revision 2)
Show all issues
```
 'ChecklistItem' imported but unused
```
checklist/checklist/resources/checklist_resource.py (Diff revision 2)
Show all issues
```
Col: 53
 E261 at least two spaces before inline comment
```

Change Summary:

Fix ReviewBot issues.

Diff:

Revision 3 (+415 -336)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/models.py
	checklist/checklist/resources/__init__.py
	checklist/checklist/resources/checklist_item.py
	checklist/checklist/resources/checklist_resource.py
	checklist/checklist/static/css/style.less
	checklist/checklist/static/js/models/checklist.js
	checklist/checklist/static/js/models/checklistAPI.js
	2 more

Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html



Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html

<p>I'm confused. The model has the id fields for the checklist items as integers, but you convert them to strings all over the place. Why aren't we just using integers?</p>

Sunxperous April 12, 2015, 10:11 a.m.

Sorry, the comment in the model is incorrect, checklist item IDs should be strings at the moment. It was already a str when I took over this project. I plan on keeping the string type for IDs especially for nested items. For example, id: '2_1' will mean that it's an item 1 nested under an item 2. Alternatively, IDs as integers work too, but I will not rule out the possibility of using strings yet.

brennie April 23, 2015, 10:15 a.m.

Ah! This makes sense. Strings will work fine in this case.

checklist/checklist/extension.py (Diff revision 3)

Show all issues

The first line of this file should be:
from __future__ import unicode_literals

checklist/checklist/extension.py (Diff revision 3)
Show all issues
```
Can you put these into alphabetical order?
```
checklist/checklist/extension.py (Diff revision 3)
Show all issues
```
Undo this change.
```

checklist/checklist/models.py (Diff revision 3)

Show all issues

The first line of this file should be:
from __future__ import unicode_literals

checklist/checklist/models.py (Diff revision 3)

Show all issues

Undo this change. django, djblets, and reviewboard are all third party imports with repsect to rb-extension-pack.

checklist/checklist/models.py (Diff revision 3)

Show all issues

Docstrings should be of the following form:

"""Single line summary

Multi-line description.
"""

checklist/checklist/models.py (Diff revision 3)

Show all issues

If we're going to put a code example in the docstring, we should be using a restructured text code block.

checklist/checklist/models.py (Diff revision 3)
Show all issues
```
"A JSON blob"
```

checklist/checklist/models.py (Diff revision 3)

Show all issues

This should probably be six.text_type (from django.utils.six), not str. If this should be a byte string type, use six.binary_type instead.

checklist/checklist/models.py (Diff revision 3)

Show all issues

Same comment about six.text_type vs str applies here.

checklist/checklist/models.py (Diff revision 3)
Show all issues
```
You don't need pass if the class has a docstring.
```
checklist/checklist/resources/__init__.py (Diff revision 3)
Show all issues
```
Same comment here about unicode_literals.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Same comment about unicode_literals as above.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Blank line between these.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Shouldn't this be int ?
The model indicates that ids are integers.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Missing trailing comma.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
This should be six.text_type.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Missing trailing comma.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Missing trailing comma.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Missing trailing comma.
```

checklist/checklist/resources/checklist_item.py (Diff revision 3)

Show all issues

Can you catch CheckListItem.DoesNotExist here instead?

Sunxperous April 12, 2015, 10:11 a.m.

Just using this comment as a reminder (checklist item? hah) that this should probably be Checklist.DoesNotExist.

checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
six.text_type, not str
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
six.text_type
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Can you catch CheckListItem.DoesNotExist here instead?
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
six.text_type
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Should have a trailing comma.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Trailing comma
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Trailing comma.
```
checklist/checklist/resources/checklist_item.py (Diff revision 3)
Show all issues
```
Can you catch CheckListItem.DoesNotExist here instead?
```

checklist/checklist/resources/checklist_item.py (Diff revision 3)

Show all issues

You can add checklist_item_id as a paramter to the function and just refer to it that way. Its cleaner than indexing into kwargs. Same elsewhere.

checklist/checklist/resources/checklist_resource.py (Diff revision 3)
Show all issues
```
This shoudl have from __future__ import unicode_literals
```
checklist/checklist/static/js/models/checklist.js (Diff revision 3)
Show all issues
```
"ID"
```

checklist/checklist/static/js/models/checklist.js (Diff revision 3)

Show all issues

Is this left over from debugging?

Sunxperous April 12, 2015, 10:11 a.m.

I meant for this to be an assertion, although it does not check if this.collection is null, which sometimes causes the statement to error instead of being asserted. Apart from that, is the assertion being used correctly in this case?

brennie April 13, 2015, 8:36 p.m.

If its sometimes causing with an error with this.collection being null, that should probably be checked, too.
I'm not sure if we leave asserts in our client JS code; you should probably ask David or Christian about this.
If this does get left in, make sure to move the var statement above it; the actual assignment can be done below it.

Sunxperous April 23, 2015, 9:46 a.m.

I will assume that asserts are allowed in client JS code for now.

checklist/checklist/static/js/models/checklist.js (Diff revision 3)

Show all issues

This should be formatted the same as a Python docstring. This applies to all methods.

checklist/checklist/static/js/models/checklist.js (Diff revision 3)

Show all issues

Can we just use response.checklist_item.keys() here?

Sunxperous April 12, 2015, 10:11 a.m.

The map function returns the values instead of keys. Which also means I can use _.values(response.checklist_item) from Underscore.js. /reminder

checklist/checklist/static/js/models/checklist.js (Diff revision 3)

Show all issues

I feel like since we're using this all over the file, and we always have access to the Checklist object, that this should be a constant on the parent Checklist object.

checklist/checklist/static/js/views/checklistView.js (Diff revision 3)
Show all issues
```
"The"
```
checklist/checklist/static/js/views/checklistView.js (Diff revision 3)
Show all issues
```
review_request_id shouldn't be quoted.
```
checklist/checklist/static/js/views/checklistView.js (Diff revision 3)
Show all issues
```
How about _addItemToView ?
```

Change Summary:

Fix trivial issues.

Diff:

Revision 4 (+427 -337)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/models.py
	checklist/checklist/resources/__init__.py
	checklist/checklist/resources/checklist_item.py
	checklist/checklist/resources/checklist_resource.py
	checklist/checklist/static/css/style.less
	checklist/checklist/static/js/models/checklist.js
	checklist/checklist/static/js/models/checklistAPI.js
	2 more

Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html



Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html

Change Summary:

Use six.text_type instead of str.
Use reStructuredText in comment block.
Improvements for comments, variables and Python method arguments.

Commit:

-	74ba2ebb4e3ac643db885d2a56d1fe5928d7dd72
+	d7e1a99f7c04c5abdd3c6b8fb0d7373684e8dc18

Diff:

Revision 5 (+438 -339)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/models.py
	checklist/checklist/resources/__init__.py
	checklist/checklist/resources/checklist_item.py
	checklist/checklist/resources/checklist_resource.py
	checklist/checklist/static/css/style.less
	checklist/checklist/static/js/models/checklist.js
	checklist/checklist/static/js/models/checklistAPI.js
	2 more

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html



Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html

checklist/checklist/models.py (Diff revision 5)

Show all issues

I think it would be ok to include the keys we expect in there (id, checked, description ?).

checklist/checklist/models.py (Diff revision 5)

Show all issues

Won't this start indexing from 1? Shouldn't we index from 0?

checklist/checklist/models.py (Diff revision 5)

Show all issues

I don't believe you should be using a dummy model for the web API. Models are not required.

checklist/checklist/resources/checklist_item.py (Diff revision 5)
Show all issues
```
This will end up in public-facing documentation.
```
checklist/checklist/resources/checklist_item.py (Diff revision 5)
Show all issues
```
We don't really need this.
```
checklist/checklist/static/js/models/checklist.js (Diff revision 5)
Show all issues
```
Can we put a doc comment on this?
```

checklist/checklist/static/js/models/checklist.js (Diff revision 5)

Show all issues

Doc comments should be of the form

/*
 * Single line summary.
 * 
 * Multi-line description.
 */

Same elsewhere.

checklist/checklist/static/js/models/checklist.js (Diff revision 5)
Show all issues
```
Needs a doc comment.
```
checklist/checklist/static/js/models/checklist.js (Diff revision 5)
Show all issues
```
Needs long-form doc comment.
```

checklist/checklist/static/js/models/checklist.js (Diff revision 5)

Show all issues

It technically isn't a dictionary -- its a JS object. You could call it a mapping, instead.

checklist/checklist/static/js/models/checklist.js (Diff revision 5)
Show all issues
```
Needs doc comment.
```
checklist/checklist/static/js/models/checklist.js (Diff revision 5)
Show all issues
```
Needs doc comment.
```
checklist/checklist/static/js/views/checklistView.js (Diff revision 5)
Show all issues
```
Should use long form doc comment. Same elsewhere.
```

Change Summary:

Update comments and docs.
Checklist item indices now starts from 0 instead of 1.

Description:

		Refactoring includes

		Use of `request.user` instead of passing `user_id` in every HTTP request
		Updating of the view only after successful API response
		Renamed status of each item from `finished` to `checked`
		Use of `ChecklistItem` non-database resource API instead of using HTTP request parameters
		Moving of front-end API logic from view to model
		CSS hyphens everywhere instead of underscores
		Improving Python code (renaming variables, removing redundant code)
	+	Start checklist item IDs from 0 instead of 1.

Commit:

-	d7e1a99f7c04c5abdd3c6b8fb0d7373684e8dc18
+	a4bc78a7853d6e01dcf148b12ed281700a756a2a

Diff:

Revision 6 (+452 -339)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/models.py
	checklist/checklist/resources/__init__.py
	checklist/checklist/resources/checklist_item.py
	checklist/checklist/resources/checklist_resource.py
	checklist/checklist/static/css/style.less
	checklist/checklist/static/js/models/checklist.js
	checklist/checklist/static/js/models/checklistAPI.js
	2 more

Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html



Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html

checklist/checklist/models.py (Diff revision 6)

Show all issues

If you are referring to Python data types, this is actually a six.text_type.

checklist/checklist/models.py (Diff revision 6)
Show all issues
```
Same here.
```

Change Summary:

Six is lucky seven ate nine.

Commit:

-	a4bc78a7853d6e01dcf148b12ed281700a756a2a
+	6fdc85454decac337d0e8b76ff877441eede6da8

Diff:

Revision 7 (+452 -339)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/models.py
	checklist/checklist/resources/__init__.py
	checklist/checklist/resources/checklist_item.py
	checklist/checklist/resources/checklist_resource.py
	checklist/checklist/static/css/style.less
	checklist/checklist/static/js/models/checklist.js
	checklist/checklist/static/js/models/checklistAPI.js
	2 more

Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html



Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html

checklist/checklist/models.py (Diff revision 7)
Show all issues
```
Can you fix up this docstring?
```

Change Summary:

Fix docstring.

Commit:

-	6fdc85454decac337d0e8b76ff877441eede6da8
+	21244921718869a60cc09123714ad76bd2e1a406

Diff:

Revision 8 (+457 -341)

Show changes

	checklist/checklist/extension.py
	checklist/checklist/models.py
	checklist/checklist/resources/__init__.py
	checklist/checklist/resources/checklist_item.py
	checklist/checklist/resources/checklist_resource.py
	checklist/checklist/static/css/style.less
	checklist/checklist/static/js/models/checklist.js
	checklist/checklist/static/js/models/checklistAPI.js
	2 more

Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html



Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py
    checklist/checklist/resources/checklist_item.py
    checklist/checklist/extension.py
    checklist/checklist/resources/__init__.py
    checklist/checklist/resources/checklist_resource.py

Ignored Files:
    checklist/checklist/static/js/views/checklistView.js
    checklist/checklist/static/js/models/checklistAPI.js
    checklist/checklist/static/css/style.less
    checklist/checklist/static/js/models/checklist.js
    checklist/checklist/templates/checklist/template.html

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (27afa78)