Reduce spurious logging for file attachments.

Review Request #7174 — Created April 6, 2015 and submitted

Information

Review Board
release-2.5.x
14f6dc0...

Reviewers

In cases where a mimetype handler or review UI rejects a given file attachment,
we log the output. This is useful for knowing, for example, why the PDF review
UI isn't trying to render for something which has mimetype application/pdf but
is actually a .docx file. However, in this case we were also logging with
`exc_info` turned on, which filled the log file with useless backtraces. This
change removes those.

 
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/ui/base.py
        reviewboard/attachments/mimetypes.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/ui/base.py
        reviewboard/attachments/mimetypes.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (e6c3a7e)
Loading...