[WIP] Allow replying to reviews from the diffviewer/text based file attachments/screenshots
Review Request #7172 — Created April 6, 2015 and discarded
Information | |
---|---|
wudi | |
Review Board | |
master | |
Reviewers | |
reviewboard, students | |
The only way to reply to reviews are from the
View Reviews
page. Although all the comments can be seen in the diffviewer/text based file attachments/screenshots, they are not organized in the review and review reply hierarchy. The comments in the comment editor dialog are also not rendered and are shown in the raw text form. Although draft review replies are shown in the comment editor textarea, it is not possible to make any changes to them. Viewing and replying to reviews will redirect the page to theView Reviews
page.This new feature will allow users to reply to reviews from the other reviews pane in the comment editor. Upon clicking on
reply
, the other reviews pane will expand and display the inline comment editor, similar to one in theView Reviews
page. The UI for publishing and discarding review replies is more tricky and has not been determined.The inline editor has been integrated into the other reviews pane of the comment editor dialog. If a draft reply to that comment exists, it would be shown with a green username with an edit icon beside the username. If not, the reply butoon will be displayed at the top right corner, clicking it will display the editor.
This change only allows for creating new replies to comments, publishing and discarding of review replies are only available in the
View Reviews
page.
Manually tested by replying to existing comments in the 3 pages - diffviewer/text based file attachments/screenshots:
- Creating new comment replies without an existing draft review reply. A new draft review reply is created with it.
- Creating new comment replies for existing draft review replies.
- Updating comment replies for existing draft review replies.
Description | From | Last Updated |
---|---|---|
So I know this is inconsistent with the comment_dict above, but can you make comment_replies_dict a collections.defaultdict(list) ? That way … |
|
|
Blank line between statement and block. |
|
|
Can you put a blank line between these? It makes it easier to read with an inline function. |
|
|
Does this go over line length if you put .appendTo($replies) on the previous line? |
|

-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py reviewboard/reviews/context.py Ignored Files: reviewboard/static/rb/js/views/abstractCommentBlockView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/commentDialogReviewView.js reviewboard/static/rb/css/pages/reviews.less
Description: |
|
||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||||||||
Diff: |
Revision 2 (+337 -87) |
||||||||||||||||||||||||
Added Files: |

-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py reviewboard/reviews/context.py Ignored Files: reviewboard/static/rb/js/views/abstractCommentBlockView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/commentDialogReviewView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/reviewReplyEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py reviewboard/reviews/context.py Ignored Files: reviewboard/static/rb/js/views/abstractCommentBlockView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/commentDialogReviewView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/reviewReplyEditorView.js
-
-
reviewboard/reviews/context.py (Diff revision 2) So I know this is inconsistent with the
comment_dict
above, but can you makecomment_replies_dict
acollections.defaultdict(list)
?That way you can just do
comment_replies_dict[parent_id].append(...)
. -
-
reviewboard/static/rb/css/pages/reviews.less (Diff revision 2) I'm guessing you're applying direct descendant selector because of rendered Markdown beneath this, right?
-
reviewboard/static/rb/js/views/abstractCommentBlockView.js (Diff revision 2) Can you put a blank line between these? It makes it easier to read with an inline function.
-
reviewboard/static/rb/js/views/commentDialogReviewView.js (Diff revision 2) Does this go over line length if you put
.appendTo($replies)
on the previous line?
Change Summary:
- Bind the updated reply values to the existing
serializedComments
so that closing and opening the comment editor will not result in the old reply being displayed. - Updates the comment block tooltips after updating replies.
- Display replies for text based file attachments and screenshots.
Summary: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||
Testing Done: |
|
||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||
Diff: |
Revision 3 (+422 -91) |
||||||||||||||||||||||||||||||
Added Files: |

-
Tool: Pyflakes Processed Files: reviewboard/reviews/ui/base.py reviewboard/staticbundles.py reviewboard/reviews/ui/text.py reviewboard/reviews/context.py Ignored Files: reviewboard/static/rb/js/views/abstractCommentBlockView.js reviewboard/static/rb/js/views/commentDialogReviewView.js reviewboard/static/rb/js/views/abstractReviewableView.js reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/commentDialogView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/ui/base.py reviewboard/staticbundles.py reviewboard/reviews/ui/text.py reviewboard/reviews/context.py Ignored Files: reviewboard/static/rb/js/views/abstractCommentBlockView.js reviewboard/static/rb/js/views/commentDialogReviewView.js reviewboard/static/rb/js/views/abstractReviewableView.js reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/commentDialogView.js