-
-
reviewboard/webapi/resources/base_review.py (Diff revision 1) Col: 13 E115 expected an indented block (comment)
Revokable ship it labels
Review Request #7170 — Created April 5, 2015 and discarded
Added removable ship it labels such that a ship it label can be revoked only by the person who endorsed it in the first place. To revoke a ship it, click
on the X to the right of a ship it label. Ship its can be revoked and the changes seen immediately. Furthermore, the ship-it counter corrresponding to the review request is duly updated(decremented) when a ship it is revoked.
Manual testing using different users and reviews, and checking if appropriate permissions are met.
Manual tests for ship its being revoked on click, and asynchronously. Furthermore, any checks to see if
review request is up to date returns true.
Unit tests for if ship it counter is being updated appropriately.
Description | From | Last Updated |
---|---|---|
Col: 13 E115 expected an indented block (comment) |
reviewbot | |
Missing one empty line |
XU xuanyi | |
How about just _revokeShipIt ? |
brennie | |
Missing one space between the key and value |
XU xuanyi | |
Missing one empty line |
XU xuanyi | |
How about _removeShipItLabel ? |
brennie | |
We should also be able to remove Ship-Its from "Fix it, then Ship it" reviews. |
brennie | |
The import should be in alphabetical order |
XU xuanyi | |
This needs to be updated to reflect the fact that the review can be updated to revoke the ship-it ness … |
brennie | |
Why this logic? By the time we get here, we've already determined that the user has to have modify permissions … |
brennie | |
Col: 13 E115 expected an indented block (comment) |
reviewbot | |
What if review.ship_it = False prior to assining to it? I believe this can result in incorrect ship-it counters. As … |
brennie | |
Left over from debugging? |
brennie | |
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (86 > 79 characters) |
reviewbot | |
Col: 9 E115 expected an indented block (comment) |
reviewbot | |
Col: 61 E231 missing whitespace after ',' |
reviewbot | |
Col: 80 E501 line too long (84 > 79 characters) |
reviewbot | |
Col: 38 E127 continuation line over-indented for visual indent |
reviewbot | |
Col: 15 E225 missing whitespace around operator |
reviewbot | |
Col: 15 E225 missing whitespace around operator |
reviewbot | |
Col: 15 E225 missing whitespace around operator |
reviewbot |
Summary: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
Change Summary:
Added Event Listeners for saved model. When Ship it is Revoked, decremented ship it counter.
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+48 -6) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/base_review.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/views/reviewBoxView.js Tool: Pyflakes Processed Files: reviewboard/webapi/resources/base_review.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/views/reviewBoxView.js
-
reviewboard/webapi/resources/base_review.py (Diff revision 2) Col: 13 E115 expected an indented block (comment)
-
-
-
reviewboard/static/rb/js/views/reviewBoxView.js (Diff revision 2) Missing one space between the key and value
-
-
reviewboard/webapi/resources/base_review.py (Diff revision 2) The import should be in alphabetical order
-
-
-
-
reviewboard/templates/reviews/boxes/review.html (Diff revision 2) We should also be able to remove Ship-Its from "Fix it, then Ship it" reviews.
-
reviewboard/webapi/resources/base_review.py (Diff revision 2) This needs to be updated to reflect the fact that the review can be updated to revoke the ship-it ness of the review.
-
reviewboard/webapi/resources/base_review.py (Diff revision 2) Why this logic?
By the time we get here, we've already determined that the user has to have modify permissions on the review.Also, this makes the
ship_it
key mandatory for updating the review. I don't think that is necessary. -
reviewboard/webapi/resources/base_review.py (Diff revision 2) What if
review.ship_it = False
prior to assining to it? I believe this can result in incorrect ship-it counters.As I understand it, the
ReviewResource
(which inherits fromBaseReviewResource
) is also used for review drafts (theReviewDraftResource
is just a redirection to it). Won't toggling theshipit
-ness of a draft review end up decrementing the ship-it count? -
Change Summary:
Added Tests and fixed minor logic bugs
Description: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||
Diff: |
Revision 3 (+100 -7) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/test_review.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/tests/test_review_request.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/views/reviewBoxView.js Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/test_review.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/tests/test_review_request.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/views/reviewBoxView.js
-
reviewboard/webapi/resources/base_review.py (Diff revision 3) Col: 80 E501 line too long (81 > 79 characters)
-
reviewboard/webapi/resources/base_review.py (Diff revision 3) Col: 80 E501 line too long (86 > 79 characters)
-
reviewboard/webapi/resources/base_review.py (Diff revision 3) Col: 9 E115 expected an indented block (comment)
-
reviewboard/webapi/resources/base_review.py (Diff revision 3) Col: 61 E231 missing whitespace after ','
-
reviewboard/webapi/resources/base_review.py (Diff revision 3) Col: 80 E501 line too long (84 > 79 characters)
-
reviewboard/webapi/tests/test_review.py (Diff revision 3) Col: 38 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_request.py (Diff revision 3) Col: 15 E225 missing whitespace around operator
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+101 -6) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/test_review.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/tests/test_review_request.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/views/reviewBoxView.js Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/test_review.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/tests/test_review_request.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/views/reviewBoxView.js
-
reviewboard/webapi/tests/test_review_request.py (Diff revision 4) Col: 15 E225 missing whitespace around operator
Change Summary:
Fixed Style issues to ship it label
Summary: |
|
||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||
Diff: |
Revision 5 (+102 -7) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/test_review.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/tests/test_review_request.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxView.js reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/test_review.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/tests/test_review_request.py Ignored Files: reviewboard/static/rb/js/views/reviewBoxView.js reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less
-
reviewboard/webapi/tests/test_review_request.py (Diff revision 5) Col: 15 E225 missing whitespace around operator