Summary

Prevent attempting to create/delete indexes unnecessarily.

Review Request #7164 — Created April 4, 2015 and submitted April 7, 2015, 4:14 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Commit

7190ba0...

Reviewers

Groups

django-evolution

People

Description

If the db_index parameter was set to True and an index already existed
in the databse, or it was set to False and an index didn't exist in the
database, we'd still generate the SQL for the index change, leading to
errors.

We now do a better job of detecting whether we actually need to
create/delete the index. Unit tests were added to ensure this works
across databases.

Testing Done

Unit tests pass on all databases.

Solved a problem I was hitting with a real-world database.

Issues

Description	From	Last Updated
'AddField' imported but unused	reviewbot	April 4, 2015, 1:12 a.m.
'add_index_to_database_sig' imported but unused	reviewbot	April 4, 2015, 1:12 a.m.

Tool: Pyflakes
Processed Files:
    django_evolution/tests/db/postgresql.py
    django_evolution/db/common.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/test_change_field.py
    django_evolution/tests/db/mysql.py



Tool: PEP8 Style Checker
Processed Files:
    django_evolution/tests/db/postgresql.py
    django_evolution/db/common.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/test_change_field.py
    django_evolution/tests/db/mysql.py

django_evolution/tests/test_change_field.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'AddField' imported but unused
```
django_evolution/tests/test_change_field.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'add_index_to_database_sig' imported but unused
```

Change Summary:

Fixed unused imports.

Commit:

274a78e4aa1f31c3ca2f4e7b9dd33d264d630076

7190ba0853d3168e4bf9b1611ccb470127a5ce6f

Diff:

Revision 2 (+113 -1)

Show changes

	django_evolution/db/common.py
	django_evolution/tests/test_change_field.py
	django_evolution/tests/db/mysql.py
	django_evolution/tests/db/postgresql.py
	django_evolution/tests/db/sqlite3.py

Tool: Pyflakes
Processed Files:
    django_evolution/tests/db/postgresql.py
    django_evolution/db/common.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/test_change_field.py
    django_evolution/tests/db/mysql.py



Tool: PEP8 Style Checker
Processed Files:
    django_evolution/tests/db/postgresql.py
    django_evolution/db/common.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/test_change_field.py
    django_evolution/tests/db/mysql.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (e03dc33)