Summary

Linkify various pieces of text in the Description and Testing Done fields

Review Request #714 — Created Jan. 21, 2009 and submitted

Information

Owner

chipx86

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

258

Depends On

Reviewers

Groups

reviewboard

People

Description

This implements support for linkifying pieces of text in the Description and Testing Done fields. Specifically, the following are linkified:

* URLs
* /r/123 numbers (even /r/123/diff and such)
* bug/issue numbers (in the form of "bug abc123", "bug #abc123", "issue abc123", and "issue #abc123")

Testing Done

Tested various links. They all seemed to work correctly. It didn't seem that unintentional links ended up forming in my tests.

I don't quite see how this works with editing?  Specifically, if someone puts a URL in the text of the description box, when they save, does it become a link? When they edit it again, do they see <a= ...> or does it de-linkify it?

chipx86 Jan. 22, 2009, 5:29 a.m.

This is already handled by the inline editors. They strip tags from the string. When editing the field, the user will just see text, and after saving, it will contain links. Editing again will turn the links back into text. I can give you a demo if you want to see it.

david Jan. 22, 2009, 5:50 a.m.

If you claim it works, I believe you. Ship it!