Summary

Fetch patches from individual commits

Review Request #7133 — Created March 28, 2015 and submitted March 28, 2015, 5:39 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

dvcs

Bugs

Depends On

~~7132~~

Commit

45149a3...

Reviewers

Groups

rbtools

People

Description

The patch fetching behaviour of both the DiffResource and the

FileDiffResource has been refactored out into the

BasePatchResource. This base class is used for the

DiffCommitResource to fetch patch files for individual commits.

Testing Done

Ran unit tests.

Manually printed the contents of a patch from the
DiffCommitResource and verified it was correct.

Issues

Description	From	Last Updated
If you have a docstring you don't need pass here.	david	March 28, 2015, 5:23 p.m.
Same.	david	March 28, 2015, 5:23 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/resource.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/resource.py

rbtools/api/resource.py (Diff revision 1)
The issue has been resolved. Show all issues
```
If you have a docstring you don't need pass here.
```
rbtools/api/resource.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same.
```

Commit:

e19df1117cab6577ce03d39969dcf2d92cdab081

45149a338ce22bb1d3bbbba132690bb7c64d194b

Diff:

Revision 2 (+15 -16)

Show changes

rbtools/api/resource.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/resource.py



Tool: Pyflakes
Processed Files:
    rbtools/api/resource.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to dvcs (9a3377e)

rbtools/api/resource.py (Diff revision 1)

rbtools/api/resource.py (Diff revision 1)