Summary

Fix generated links for DiffCommit resources

Review Request #7132 — Created March 28, 2015 and submitted March 28, 2015, 5:15 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Blocks

7133

Commit

6ded1ed...

Reviewers

Groups

reviewboard

People

Description

Fix generated links for DiffCommit resources

Previously, the generated links for the DiffCommitResource and
DraftDiffCommitResource were being overridden by the resources for
the parent DiffResource or DraftDiffResource, respectively. Now,
only the files link is taken from the parent resource and the other
links are not overriden

Testing Done

Ran unit test.

Checked the links of a DiffCommitResource and saw that they were
correct.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/diff_commit.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/diff_commit.py

Commit:

-	f7ab76cdcae71a641e9aa495c72428c8860d46cd
+	56f2612d9f9a0fa2bddb5c34d349cfda6a328f43

Diff:

Revision 2 (+12 -13)

Show changes

reviewboard/webapi/resources/diff_commit.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/diff_commit.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/diff_commit.py

Ship it!

```
Ship It!
```

Change Summary:

Also generate link correctly for drafts.

Commit:

-	56f2612d9f9a0fa2bddb5c34d349cfda6a328f43
+	6ded1ed4626e8a88fdb8ed1a72ca473aa8d1758a

Diff:

Revision 3 (+15 -16)

Show changes

	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff_commit.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/resources/diff_commit.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/resources/diff_commit.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (16c9238)