Summary

Allow fetching patch files for individual commits

Review Request #7131 — Created March 28, 2015 and submitted March 28, 2015, 5:25 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

~~7130~~

Commit

4b3d41f...

Reviewers

Groups

reviewboard

People

Description

The patch file for an individual commit is now fetchable by sending the
Accept: text/x-patch header to the DiffCommitResource and
DraftDiffCommitResource. This patch is composed of the individual
patches for all FileDiffs in the DiffCommit.

Testing Done

Ran unit tests.

Uploaded a review request with commit history and made an HTTP request
to the DiffCommitResource API endpoint with a Accept: text/x-patch
header. The returned response was a patch file that contained only the
diff information for FileDiffs in that commit.

Issues

Description	From	Last Updated
Blank line above this.	david	March 28, 2015, 5:18 p.m.
While I don't expect it to be a problem, we should make sure this doesn't contain commas.	david	March 28, 2015, 5:01 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/parser.py
    reviewboard/webapi/resources/diff_commit.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/parser.py
    reviewboard/webapi/resources/diff_commit.py

Summary:

-	Add timestamp field to the DiffCommit model
+	Allow fetching patch files for individual commits

Description:

-		Allow fetching patch files for individual commits
-
		The patch file for an individual commit is now fetchable by sending the
		`Accept: text/x-patch` header to the `DiffCommitResource` and
		`DraftDiffCommitResource`. This patch is composed of the individual
		patches for all `FileDiff`s in the `DiffCommit`.

reviewboard/webapi/resources/diff_commit.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line above this.
```

reviewboard/webapi/resources/diff_commit.py (Diff revision 1)

The issue has been dropped. Show all issues

While I don't expect it to be a problem, we should make sure this doesn't contain commas.

brennie March 28, 2015, 5 p.m.

The commit_id cannot contain commas. We ensure that it is alphanumeric when we store it in the DB.

Change Summary:

Fixup

Commit:

-	59f38d01d8042a824179bd472f22ac7278c3dc8a
+	4b3d41fb19dbad38788ce06fe30b414dca3c9f0e

Diff:

Revision 2 (+51 -5)

Show changes

	reviewboard/diffviewer/parser.py
	reviewboard/webapi/resources/diff_commit.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/parser.py
    reviewboard/webapi/resources/diff_commit.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/parser.py
    reviewboard/webapi/resources/diff_commit.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (da4fab8)