post-review: User username/password arguments for login when provided
Review Request #713 — Created Jan. 21, 2009 and submitted
The post-review script should use values provided in username/password argument when provided. Currently it first looks for cookie and if valid cookie is found the username/password arguments are ignored. Hence if I need to use different login than one I use regularly, the cookie needs to be deleted. With this change, username/password arguments are given higher priority than the session cookie.
-
Sorry for the delay on this. Been too busy to get to reviews lately. This is looking better, but it breaks submit_as. Shouldn't be a hard fix, but we need to make sure that username is set to options.submit_as if options.username is not provided and options.submit_as is. Probably can do something as simple as: username = options.username or options.submit_as We'd need this tested before it can go in though. Should be simple, just need a test user with the can_submit_as_user permission.