Summary

Provide file attachment revision info in the API and JavaScript.

Review Request #7116 — Created March 25, 2015 and submitted March 25, 2015, 6:57 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

2660d6f...

Reviewers

Groups

reviewboard

People

Description

The file attachment resources were missing revision information, which
we'll soon be needing in the UI. A revision field has been added to
the serialized data for file attachments in the API.

The JavaScript resource models load in the revision information from the
API into an attribute, and default the diffAgainstFileAttachment
attribute to null (instead of undefined).

Testing Done

Python and JavaScript ynit tests pass.

Used these values in another change.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/tests/test_file_attachment.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentModel.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentModelTests.js



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/tests/test_file_attachment.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js
    reviewboard/static/rb/js/resources/models/fileAttachmentModel.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentModelTests.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (503d12a)