Summary

Added a mercurial hook for posting review requests when pushing to central repo.

Review Request #7100 — Created March 21, 2015 and discarded Jan. 29, 2019, 1:40 p.m.

Information

Owner

halvorlu

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

A Mercurial hook to post to Review Board on push to a central server.

The hook was designed to make posting to Review Board easy for new or inexperienced users. It allows user to post to ReviewBoard by using the ordinary "hg push", without any need to learn or install RBTools locally.

The hook only allows the push if all commits have been approved in a review requests, otherwise it rejects it and creates a review request for the (new) commits. This is similar to "rbt post", but
1. does not require the user to install RBTools locally
2. makes sure any changes pushed to the central server have been reviewed and approved
3. makes links of all references to tickets/bugs/issues, which rbt post doesn't do.
4. automatically finds the right review request to update if there are any new commits, based the commit ID and a date/author hash. This does not require the user to confirm anything, which rbt post (often) requires. This also allows the hook to recognize rebased/amended changesets, because the date/author hash is unchanged.

Testing Done

The hook has been tested both with some unit testing and partly in a production environment.
Unit testing also included testing communication with server, which revealed a few issues that have been fixed.
I wasn't sure how these unit tests should be included in the test suites for RBTools, so I've left them out for now.

Issues

Description	From	Last Updated
Col: 61 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:04 p.m.
Col: 68 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:04 p.m.
Col: 39 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:04 p.m.
Col: 42 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 21, 2015, 4:04 p.m.
Col: 44 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:04 p.m.
'from rbtools.hooks.mercurial import *' used; unable to detect undefined names	reviewbot	April 1, 2015, 12:36 a.m.
Col: 59 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:04 p.m.
Col: 63 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:04 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 21, 2015, 4:05 p.m.
Col: 42 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:05 p.m.
Col: 51 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:05 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	April 1, 2015, 12:36 a.m.
Col: 61 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:05 p.m.
Col: 68 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:05 p.m.
Col: 39 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:05 p.m.
Col: 42 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 21, 2015, 4:05 p.m.
Col: 44 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:05 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	April 1, 2015, 12:36 a.m.
Col: 61 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:04 p.m.
Col: 68 E226 missing whitespace around arithmetic operator	reviewbot	March 21, 2015, 4:04 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	April 1, 2015, 12:36 a.m.
'from rbtools.hooks.mercurial import *' used; unable to detect undefined names	reviewbot	April 1, 2015, 12:36 a.m.
Col: 23 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 22 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 21 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 27 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 23 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 23 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 61 E226 missing whitespace around arithmetic operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 30 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 68 E226 missing whitespace around arithmetic operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 29 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 25 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 30 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:36 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	April 1, 2015, 12:37 a.m.
'from rbtools.hooks.mercurial import *' used; unable to detect undefined names	reviewbot	April 1, 2015, 12:37 a.m.
Col: 23 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 22 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 21 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 27 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 23 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 23 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 61 E226 missing whitespace around arithmetic operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 30 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 68 E226 missing whitespace around arithmetic operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 29 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 25 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 30 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 26 W503 line break before binary operator	reviewbot	April 1, 2015, 12:37 a.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	April 1, 2015, 12:37 a.m.
Col: 59 E226 missing whitespace around arithmetic operator	reviewbot	April 1, 2015, 12:35 a.m.
Col: 66 E226 missing whitespace around arithmetic operator	reviewbot	April 1, 2015, 12:35 a.m.
Col: 59 E226 missing whitespace around arithmetic operator	reviewbot	April 6, 2015, 4:23 a.m.
Col: 66 E226 missing whitespace around arithmetic operator	reviewbot	April 6, 2015, 4:23 a.m.
Col: 22 W503 line break before binary operator	reviewbot	April 6, 2015, 4:23 a.m.
Branch information would be helpful	misery	April 11, 2015, 10:45 a.m.
I think a new request should be in draft mode to allow the developer additional changes. Immediately public for updated …	misery	April 11, 2015, 10:45 a.m.
This could fail if there is no address or the admin marked his profile information as private.	misery	April 11, 2015, 10:45 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 12, 2015, 1:22 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 12, 2015, 1:22 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 12, 2015, 1:22 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 12, 2015, 1:22 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	April 12, 2015, 1:22 a.m.
Col: 29 E226 missing whitespace around arithmetic operator	reviewbot	April 12, 2015, 1:22 a.m.
Col: 29 E226 missing whitespace around arithmetic operator	reviewbot	April 12, 2015, 1:22 a.m.
Col: 29 E226 missing whitespace around arithmetic operator	reviewbot	April 12, 2015, 1:22 a.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	April 12, 2015, 1:22 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 12, 2015, 1:22 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 12, 2015, 1:22 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	April 12, 2015, 1:22 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 12, 2015, 1:22 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 12, 2015, 1:22 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 12, 2015, 1:22 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 12, 2015, 1:22 a.m.
These imports should follow the PEP-8 standard (3 sections, first standard library, then third party, then "local" imports). We also …	david	April 15, 2015, 12:12 p.m.
We should avoid using str (which has different meanings in python 2 and 3) and instead use six.text_type	david	April 18, 2015, 3:44 a.m.
Please add a blank line before this.	david	April 18, 2015, 3:44 a.m.
You don't need the + here, since strings will auto concatenate. Can we also say "repository's" instead of "repo's"?	david	April 18, 2015, 3:44 a.m.
Please add a blank line before this.	david	April 18, 2015, 3:44 a.m.
This check should be not ticket_url	david	April 18, 2015, 3:44 a.m.
We generally use older-style format strings (`'%d changesets recieved' % len(changesets).	david	April 18, 2015, 3:44 a.m.
Please add blank lines around the conditional blocks here and below.	david	April 18, 2015, 3:44 a.m.
For multi-line docstrings, the closing """ should go on the next line.	david	April 18, 2015, 3:44 a.m.
You can skip the [] inside all and it will be a bit more efficient (using a generator expression instead …	david	April 18, 2015, 3:44 a.m.
Please use % formatting.	david	April 18, 2015, 3:44 a.m.
This looks like it's part of a different change.	david	April 18, 2015, 3:44 a.m.
""" on the next line.	david	April 18, 2015, 3:45 a.m.
The formatted-in string needs to be run through re.escape. Please also use %-formatting.	david	April 18, 2015, 3:45 a.m.
Please rearrange according to PEP-8.	david	April 18, 2015, 3:45 a.m.
Please put each key/value on its own line.	david	April 18, 2015, 3:45 a.m.
This should use six.text_type rather than str.	david	April 18, 2015, 3:45 a.m.
This should fit on one line.	david	April 18, 2015, 3:45 a.m.
Can you just put the format inline in the function call?	david	April 18, 2015, 3:45 a.m.
This could be a single statement: return max([ datetime_from_timestamp(diff.timestamp) for diff in revreq.get_diffs(only_fields='timestamp') ])	david	April 18, 2015, 3:45 a.m.
""" on the next line.	david	April 18, 2015, 3:45 a.m.
""" on the next line.	david	April 18, 2015, 3:45 a.m.
This should be "Review Board", not "ReviewBoard"	david	April 18, 2015, 3:45 a.m.
Same here.	david	April 18, 2015, 3:45 a.m.
And here.	david	April 18, 2015, 3:45 a.m.
And here.	david	April 18, 2015, 3:45 a.m.
This should all be a single format operation rather than a format and a bunch of concatenations. You can also …	david	April 18, 2015, 3:45 a.m.
Please import unicode_literals at the top of this file.	david	April 18, 2015, 3:45 a.m.
Docstrings for TestCase test methods shouldn't end in periods.	david	April 18, 2015, 3:45 a.m.
Docstrings for TestCase test methods shouldn't end in periods.	david	April 18, 2015, 3:45 a.m.
Docstrings for TestCase test methods shouldn't end in periods.	david	April 18, 2015, 3:45 a.m.
'itertools' imported but unused	reviewbot	April 18, 2015, 3:48 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 18, 2015, 3:48 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 18, 2015, 3:48 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 18, 2015, 3:48 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 18, 2015, 3:48 a.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	April 18, 2015, 3:48 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 18, 2015, 3:48 a.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	April 18, 2015, 3:48 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E302 expected 2 blank lines, found 0	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 18, 2015, 3:47 a.m.
Col: 27 E127 continuation line over-indented for visual indent	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	April 18, 2015, 3:47 a.m.
Col: 29 E226 missing whitespace around arithmetic operator	reviewbot	April 18, 2015, 3:47 a.m.
Col: 29 E226 missing whitespace around arithmetic operator	reviewbot	April 18, 2015, 3:47 a.m.
Col: 29 E226 missing whitespace around arithmetic operator	reviewbot	April 18, 2015, 3:47 a.m.
local variable 'repo_id2' is assigned to but never used	reviewbot	April 18, 2015, 3:47 a.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	April 18, 2015, 3:47 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 18, 2015, 3:47 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	April 18, 2015, 3:47 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 18, 2015, 3:47 a.m.
'hg' imported but unused	reviewbot	April 18, 2015, 3:47 a.m.
'ui' imported but unused	reviewbot	April 18, 2015, 3:47 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 18, 2015, 3:47 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 18, 2015, 3:47 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 18, 2015, 3:47 a.m.
Col: 19 W503 line break before binary operator	reviewbot	April 18, 2015, 3:47 a.m.
'itertools' imported but unused	reviewbot	April 18, 2015, 3:50 a.m.
Code looks for "ticket_id_prefixes"	misery	April 27, 2015, 1:41 p.m.
repo_root cannot be found here on reviewboard because reviewboard will use a remote connection like http://mercurial/scm/hg/Test. "hg root" will return …	misery	April 27, 2015, 1:41 p.m.
Documentation uses "ticket_prefixes"	misery	April 27, 2015, 1:41 p.m.
The link works if we replace "re.escape(base_url)" with "base_url", otherwise the URL is broken and reviewboard shows a broken link. …	misery	April 27, 2015, 1:40 p.m.
Missing ticket_prefixes here :-) find_ticket_refs(new_plain_description, ticket_prefixes)	misery	April 27, 2015, 1:39 p.m.
Col: 19 W503 line break before binary operator	reviewbot	April 27, 2015, 2:07 p.m.
Col: 19 W503 line break before binary operator	reviewbot	April 27, 2015, 2:07 p.m.
Col: 19 W503 line break before binary operator	reviewbot	April 27, 2015, 2:07 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 27, 2015, 2:08 p.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	April 27, 2015, 2:07 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 27, 2015, 2:08 p.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E302 expected 2 blank lines, found 0	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 27, 2015, 2:08 p.m.
Col: 27 E127 continuation line over-indented for visual indent	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	April 27, 2015, 2:08 p.m.
Col: 29 E226 missing whitespace around arithmetic operator	reviewbot	April 27, 2015, 2:08 p.m.
Col: 29 E226 missing whitespace around arithmetic operator	reviewbot	April 27, 2015, 2:08 p.m.
Col: 29 E226 missing whitespace around arithmetic operator	reviewbot	April 27, 2015, 2:08 p.m.
Col: 5 E301 expected 1 blank line, found 0	reviewbot	April 27, 2015, 2:08 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 27, 2015, 2:08 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	April 27, 2015, 2:08 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 27, 2015, 2:08 p.m.
Col: 19 W503 line break before binary operator	reviewbot	April 27, 2015, 2:08 p.m.
Col: 19 W503 line break before binary operator	reviewbot	April 27, 2015, 2:08 p.m.
Col: 19 W503 line break before binary operator	reviewbot	April 27, 2015, 2:08 p.m.
Col: 19 W503 line break before binary operator	reviewbot	April 27, 2015, 2:08 p.m.
reviewboardhook can be CONFIG_SECTION	misery	July 3, 2015, 5:56 a.m.
reviewboardhook can be CONFIG_SECTION	misery	July 3, 2015, 5:56 a.m.
This will fail if "line" is unicode. We fixed it with hasher.update(line.encode('utf-8')) UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in …	misery	Aug. 25, 2015, 10:15 a.m.
It would be nice if the "get description" could be a separate function. So we can use it to check …	misery	Oct. 13, 2015, 6:11 a.m.
If you push multiple changesets in different branches this won't work with our workflow. Could you change it to this? …	misery	July 3, 2015, 5:56 a.m.
^1 will leads to a broken "base_commit_id" See: https://code.google.com/p/reviewboard/issues/detail?id=3915 I added this as a work-around to rbtools in "clients/mercurial.py" at …	misery	Oct. 13, 2015, 6:09 a.m.
Col: 17 W503 line break before binary operator	reviewbot	July 3, 2015, 5:56 a.m.
see above	misery	Oct. 13, 2015, 6:09 a.m.
see above	misery	Oct. 13, 2015, 6:09 a.m.
base_commit_id needs to be passed here, too. Because otherwise reviewboard will use "tip" as base and this will fail if …	misery	Oct. 13, 2015, 6:09 a.m.
We changed it to this since a rebase could lead to a useless "whitespace changed"-update: if len(line) > 0 and …	misery	Oct. 13, 2015, 6:09 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/hooks/common.py
    rbtools/hooks/mercurial.py
    rbtools/hooks/mercurial_push.py
    rbtools/hooks/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/hooks/common.py
    rbtools/hooks/mercurial.py
    rbtools/hooks/mercurial_push.py
    rbtools/hooks/tests.py

rbtools/hooks/common.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 61
 E226 missing whitespace around arithmetic operator
```
rbtools/hooks/common.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 68
 E226 missing whitespace around arithmetic operator
```
rbtools/hooks/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 39
 E226 missing whitespace around arithmetic operator
```
rbtools/hooks/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 42
 E251 unexpected spaces around keyword / parameter equals
```
rbtools/hooks/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 44
 E226 missing whitespace around arithmetic operator
```
rbtools/hooks/mercurial_push.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'from rbtools.hooks.mercurial import *' used; unable to detect undefined names
```
rbtools/hooks/mercurial_push.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 59
 E226 missing whitespace around arithmetic operator
```
rbtools/hooks/mercurial_push.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 63
 E226 missing whitespace around arithmetic operator
```
rbtools/hooks/mercurial_push.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/hooks/mercurial_push.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 42
 E226 missing whitespace around arithmetic operator
```
rbtools/hooks/mercurial_push.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 51
 E226 missing whitespace around arithmetic operator
```
rbtools/hooks/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```

Commit:

edc84363172857e90ed8a4d543a7a177ccff0d26

4da915e2ecb48a0695cfe1aef28fb332963e3aea

Diff:

	contrib/tools/mercurial-push
	rbtools/hooks/common.py
	rbtools/hooks/mercurial.py
	rbtools/hooks/tests.py

		A Mercurial hook to post to ReviewBoard on push to a central server.

		The hook was designed to make posting to ReviewBoard easy for new or inexperienced users. It allows user to post to ReviewBoard by using the ordinary "hg push", without any need to learn or install RBTools locally.

		The hook only allows the push if all commits have been approved in a review requests, otherwise it rejects it and creates a review request for the (new) commits. This is similar to "rbt post", but
		1) does not require the user to install RBTools locally
~		2) makes sure any changes pushed to the central server have been reviewed and approved
	~	2) makes sure any changes pushed to the central server have been reviewed and approved
	+	3) makes links of all references to tickets/bugs/issues, which I don't think rbt post does?

	setup.py
	contrib/tools/mercurial_push.py
	rbtools/hooks/common.py
	rbtools/hooks/mercurial.py
	rbtools/hooks/tests.py

	contrib/tools/mercurial_push.py
	contrib/tools/test_reviewboardhook.py
	rbtools/hooks/common.py
	rbtools/hooks/mercurial.py
	rbtools/hooks/tests.py

	contrib/tools/mercurial_push.py
	rbtools/clients/mercurial.py
	rbtools/commands/post.py
	rbtools/hooks/common.py
	rbtools/hooks/mercurial.py
	rbtools/hooks/tests.py
	rbtools/utils/review_request.py

rbtools/hooks/common.py (Diff revision 1)

rbtools/hooks/common.py (Diff revision 1)

rbtools/hooks/mercurial.py (Diff revision 1)

rbtools/hooks/mercurial.py (Diff revision 1)