Impose a minimum version on rbt patch with SVN

Review Request #7097 — Created March 20, 2015 and submitted

Information

RBTools
release-0.7.x

Reviewers

The svn patch command was added in SVN 1.7.0 (1). We now check the
version of svn prior to attempting to execute svn patch and report
to the user that their version of svn does not support the patch
command if it is less than 1.7.0.

(1): https://subversion.apache.org/docs/release-notes/1.7.html#patch

Ran unit tests.

Able to run rbt patch when using SVN 1.7.0 and above. Not able to
run rbt patch when using SVN prior to 1.7.0.

Description From Last Updated

This doesn't see to work. Did you want: if not is_valid_version(self.subversion_client_version, self.PATCH_MIN_VERSION):

gmyersgmyers
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/svn.py
        rbtools/clients/errors.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/clients/svn.py
        rbtools/clients/errors.py
    
    
  2. 
      
gmyers
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 1)
     
     

    This doesn't see to work. Did you want:

    if not is_valid_version(self.subversion_client_version, self.PATCH_MIN_VERSION):

  3. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/svn.py
        rbtools/clients/errors.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/clients/svn.py
        rbtools/clients/errors.py
    
    
  2. 
      
gmyers
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (930991a)
Loading...