Summary

Impose a minimum version on rbt patch with SVN

Review Request #7097 — Created March 20, 2015 and submitted March 23, 2015, 2:05 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

gmyers

Description

The svn patch command was added in SVN 1.7.0 (1). We now check the
version of svn prior to attempting to execute svn patch and report
to the user that their version of svn does not support the patch
command if it is less than 1.7.0.

(1): https://subversion.apache.org/docs/release-notes/1.7.html#patch

Testing Done

Ran unit tests.

Able to run rbt patch when using SVN 1.7.0 and above. Not able to
run rbt patch when using SVN prior to 1.7.0.

Issues

Description	From	Last Updated
This doesn't see to work. Did you want: if not is_valid_version(self.subversion_client_version, self.PATCH_MIN_VERSION):	gmyers	March 21, 2015, 6:15 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py
    rbtools/clients/errors.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py
    rbtools/clients/errors.py

rbtools/clients/svn.py (Diff revision 1)

The issue has been resolved. Show all issues

This doesn't see to work. Did you want:

if not is_valid_version(self.subversion_client_version, self.PATCH_MIN_VERSION):

Diff:

Revision 2 (+14 -1)

Show changes

	rbtools/clients/errors.py
	rbtools/clients/svn.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py
    rbtools/clients/errors.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py
    rbtools/clients/errors.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.7.x (930991a)