Fix rbt patch for some SCMs.

Review Request #7091 — Created March 19, 2015 and submitted

Information

RBTools
release-0.7.x
e26dc3a...

Reviewers

Previously, rbt patch really only worked with Git, Perforce, and
Mercurial. When running rbt patch with another SCM (say, CVS) it
would crash. This is because not all SCMs knew how to check for empty
files support. Now, all SCMs default to no empty file support and
runnign rbt patch with these SCMs no longer causes rbt to crash.

Ran unit tests.

Before applying this patch, using rbt patch in a CVS repository
would cause it to crash. After applying this patch, it no longer
crashes and the patch is applied successfully.

Description From Last Updated

Should be "Check" instead of "Checks"

daviddavid

This comment is a little bit confusing. For a moment I thought we were overriding the one that the user …

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/svn.py
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/svn.py
        rbtools/clients/perforce.py
    
    
  2. 
      
david
  1. 
      
  2. rbtools/clients/__init__.py (Diff revision 1)
     
     
    Show all issues

    Should be "Check" instead of "Checks"

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/svn.py
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/svn.py
        rbtools/clients/perforce.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/svn.py
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/svn.py
        rbtools/clients/perforce.py
    
    
  2. 
      
david
  1. 
      
  2. rbtools/clients/__init__.py (Diff revision 3)
     
     
     
    Show all issues

    This comment is a little bit confusing. For a moment I thought we were overriding the one that the user specified.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/svn.py
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/svn.py
        rbtools/clients/perforce.py
    
    
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.7.x (d4b80fd)