Fix the order shown for file attachment diffs.

Review Request #7089 — Created March 19, 2015 and submitted — Latest diff uploaded

Information

Review Board
release-2.5.x
3e416f8...

Reviewers

When viewing diffs of file attachments, the displayed order between the
two revisions were reversed. For instance, on images, the new image was
being shown as the original version, and the original image was shown a
the new version.

This was due to the order in which the URL arguments were captured. In
file attachment terms, the original file is the one being diffed
against, but the URL was capturing the new file as the one being diffed
against.

Text attachments were correctly shown, but had reversed the IDs and
state. They're now using the correct variables.

This change fixes up the capture order, the template rendering for text
attachments, and the logic for text attachments, fixing all display
issues.

Tested with some revisioned images I had. The order was correct for all revisions.

    Loading...