Summary

Add revert patch support to the rbt patch command

Review Request #7084 — Created March 19, 2015 and submitted March 26, 2015, 12:27 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

~~7095~~

Commit

cb727d6...

Reviewers

Groups

rbtools

People

Description

The rbt patch command is now capable of reverting patches via the
-R/--revert command line flag.

Testing Done

Ran unit tests.

Tested rbt patch -R with CVS, Git, Perforce, and SVN.

Applied a patch with Perforce that had empty files and was able to
revert it with rbt patch -R.

Applied a patch with SVN that had empty files and was able to revert
it with rbt patch -R.

Running rbt patch -R when using a Mercurial repository results in an
error as expected.

I am not able to verify that this works with Plastic or ClearCase, but
it should work because they both use the default apply_patch method.

Issues

Description	From	Last Updated
Col: 1 W293 blank line contains whitespace	reviewbot	March 20, 2015, 3:23 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/cvs.py
    rbtools/commands/patch.py
    rbtools/clients/tfs.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/cvs.py
    rbtools/commands/patch.py
    rbtools/clients/tfs.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py

Depends On:: ~~7095 - Fix rbt patch for SVN backend~~

Testing Done:

		Ran unit tests.

~		Tested `rbt patch -R` with Git, CVS, and Perforce.
	~	Tested `rbt patch -R` with CVS, Git, Perforce, and SVN.

		Applied a patch with Perforce that had empty files and was able to
		revert it with `rbt patch -R`.

	+	Applied a patch with SVN that had empty files and was able to revert
	+	it with `rbt patch -R`.
	+
		Running `rbt patch -R` when using a Mercurial repository results in an
		error as expected.

		I am not able to verify that this works with Plastic or ClearCase, but
		it should work because they both use the default `apply_patch` method.

Branch:

master

release-0.7.x

Depends On:

~~7091 - Fix rbt patch for some SCMs.~~

Commit:

c3ab3089320464e731d60a6a7301c52f9e18ed25

cb727d6ca0fe324052bec9394b8d3a3ae4c67041

Diff:

Revision 2 (+104 -31)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/clearcase.py
	rbtools/clients/cvs.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	rbtools/clients/svn.py
	2 more

Tool: Pyflakes
Processed Files:
    rbtools/clients/cvs.py
    rbtools/commands/patch.py
    rbtools/clients/tfs.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/cvs.py
    rbtools/commands/patch.py
    rbtools/clients/tfs.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py

rbtools/clients/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Diff:

Revision 3 (+104 -31)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/clearcase.py
	rbtools/clients/cvs.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	rbtools/clients/svn.py
	2 more

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/cvs.py
    rbtools/commands/patch.py
    rbtools/clients/tfs.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/cvs.py
    rbtools/commands/patch.py
    rbtools/clients/tfs.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py

Ship it!

Looks OK, assuming the SVN stuff is taken care of. If so, can you update the description?

brennie March 26, 2015, 10:22 a.m.
```
Oops, thanks!
```

Description:: The rbt patch command is now capable of reverting patches via the
-R/--revert command line flag.
-
-
NB: This currently doesn't work with SVN because rbt patch is broken wrt SVN. This will be fixed and this patch will be rebased on that patch.

Status:: Completed
Change Summary:: Pushed to release-0.7.x (64e6fb1)

		The `rbt patch` command is now capable of reverting patches via the
		`-R`/`--revert` command line flag.
-
-		NB: This currently doesn't work with SVN because `rbt patch` is broken wrt SVN. This will be fixed and this patch will be rebased on that patch.

rbtools/clients/__init__.py (Diff revision 2)