Summary

Refactor commit-specific utils into new module

Review Request #7072 — Created March 17, 2015 and submitted March 17, 2015, 3:57 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

1d60141...

Reviewers

Groups

reviewboard

People

Description

The DiffCommitFileExistenceChecker class has been moved into the new

commitutils module, which wil hold all utility classes and functions

pertaining to DiffCommits going forward. Previously they were being

put into diffutils, but this new module seems like a better place for

them.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
This file needs the unicode_literals import.	chipx86	March 17, 2015, 3:39 p.m.
Swap these.	chipx86	March 17, 2015, 3:39 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/managers.py
    reviewboard/diffviewer/commitutils.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/managers.py
    reviewboard/diffviewer/commitutils.py

reviewboard/diffviewer/commitutils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This file needs the unicode_literals import.
```
reviewboard/diffviewer/managers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Swap these.
```

Commit:

-	316949a4525386b81c5f0687a8c2a8bc498921e1
+	1d601415db5cdec5a53ad33adaff23dd07ff6f67

Diff:

Revision 2 (+56 -54)

Show changes

	reviewboard/diffviewer/commitutils.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/managers.py

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/managers.py
    reviewboard/diffviewer/commitutils.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/diffutils.py
    reviewboard/diffviewer/managers.py
    reviewboard/diffviewer/commitutils.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (1e9ae59)