Add filters for searching.
Review Request #7063 — Created March 15, 2015 and submitted
Now that we're showing more than review requests in the search results, we need to give users the option to filter those results. There's now a filter bar above the search results, showing a tab-like view of All Results, Users, and Review Requests. Clicking one of these will re-search with a filter applied. Users can also combine filters in the URL, if they want, though there's no UI for doing so. It's an advanced feature that may be more useful down the road. While here, I removed some old, dead code from the template and context variables, and tweaked the number of pages shown in the paginator.
Tested searching with each filter type, with no filters, and with
combinations of filters. I always got the results I expected.
-
-
reviewboard/search/views.py (Diff revision 1) Would you mind putting parens around the expression passed in for
active? I know it's not necessary but I find it makes it a lot easier to read. -
reviewboard/static/rb/css/search.less (Diff revision 1) Do we not have a definition that would work here?
Change Summary:
Added parens.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+74 -11) |
-
Tool: Pyflakes Processed Files: reviewboard/search/views.py Ignored Files: reviewboard/templates/search/results.html reviewboard/static/rb/css/search.less Tool: PEP8 Style Checker Processed Files: reviewboard/search/views.py Ignored Files: reviewboard/templates/search/results.html reviewboard/static/rb/css/search.less
Tool: PEP8 Style Checker Processed Files: reviewboard/search/views.py Ignored Files: reviewboard/templates/search/results.html reviewboard/static/rb/css/search.less Tool: Pyflakes Processed Files: reviewboard/search/views.py Ignored Files: reviewboard/templates/search/results.html reviewboard/static/rb/css/search.less