Summary

Add filters for searching.

Review Request #7063 — Created March 15, 2015 and submitted March 16, 2015, 7:12 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

8cf85b3...

Reviewers

Groups

reviewboard

People

Description

Now that we're showing more than review requests in the search results,
we need to give users the option to filter those results.

There's now a filter bar above the search results, showing a tab-like
view of All Results, Users, and Review Requests. Clicking one of these
will re-search with a filter applied.

Users can also combine filters in the URL, if they want, though there's
no UI for doing so. It's an advanced feature that may be more useful
down the road.

While here, I removed some old, dead code from the template and context
variables, and tweaked the number of pages shown in the paginator.

Testing Done

Tested searching with each filter type, with no filters, and with
combinations of filters. I always got the results I expected.

Files

Issues

Description	From	Last Updated
'six' imported but unused	reviewbot	March 15, 2015, 4:08 p.m.
Would you mind putting parens around the expression passed in for active? I know it's not necessary but I find …	david	March 16, 2015, 2:40 p.m.
Do we not have a definition that would work here?	david	March 16, 2015, 2:42 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/search/views.py

Ignored Files:
    reviewboard/templates/search/results.html
    reviewboard/static/rb/css/search.less



Tool: Pyflakes
Processed Files:
    reviewboard/search/views.py

Ignored Files:
    reviewboard/templates/search/results.html
    reviewboard/static/rb/css/search.less

reviewboard/search/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'six' imported but unused
```

reviewboard/search/views.py (Diff revision 1)

The issue has been resolved. Show all issues

Would you mind putting parens around the expression passed in for active? I know it's not necessary but I find it makes it a lot easier to read.

chipx86 March 16, 2015, 1:31 p.m.

Oops, I normally would have. That's the result of turning this from a {...} to a dict(...).

reviewboard/static/rb/css/search.less (Diff revision 1)

The issue has been dropped. Show all issues

Do we not have a definition that would work here?

chipx86 March 16, 2015, 2:41 p.m.

Nope. It's part of the styling for this page, specifically, to fit in with the tab colors. Just grayish text.

Change Summary:

Added parens.

Commit:

aa2d4a4d59ac6cc5f9db6f2a77ab647e7dd6bc10

8cf85b3183cb129bc1c336c8b7075d84c5662f34

Diff:

Revision 2 (+74 -11)

Show changes

	reviewboard/search/views.py
	reviewboard/static/rb/css/search.less
	reviewboard/templates/search/results.html

Tool: Pyflakes
Processed Files:
    reviewboard/search/views.py

Ignored Files:
    reviewboard/templates/search/results.html
    reviewboard/static/rb/css/search.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/search/views.py

Ignored Files:
    reviewboard/templates/search/results.html
    reviewboard/static/rb/css/search.less

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (32499ee)