- Download Diff

Summary:

Add unit tests for git repository functions

Review Request #7053 — Created March 13, 2015 and submitted March 25, 2015, 8:46 p.m.

Information
Owner:	jyuen
Repository:	rb-gateway
Branch:	master
Bugs:
Depends On:	~~7054~~
Blocks:	7104
Commit:	bb00723...
Reviewers
Groups:	rb-gateway, students
People:

Description

Currently rb-gateway has no automated tests. This adds automated tests that checks against all functions in git_repository.go.

Testing Done

Made sure that all tests pass when running go test.

Issues

Description	From	Last Updated
If this is going to be a useful testing utility, maybe this should go in a seperate (testing.utils ?) package.	brennie	March 20, 2015, 12:17 a.m.
If I run the tests on my mac, I get this: --- FAIL: TestGetPath (0.01s) git_repository_test.go:126: Expected '/var/folders/lp/dyp18_2s6bj05n25pm0k0_880000gn/T/rb-gateway574450298/', got '/private/var/folders/lp/dyp18_2s6bj05n25pm0k0_880000gn/T/rb-gateway574450298/' ...	david	March 25, 2015, 8:45 p.m.
All fake e-mail addresses should use "example.com" (which is reserved for tests and examples), rather than pointing to a real ...	david	March 23, 2015, 11:27 p.m.

Tool: PEP8 Style Checker
Ignored Files:
    git_repository_test.go
    README.md



Tool: Pyflakes
Ignored Files:
    git_repository_test.go
    README.md

Change Summary:

Add students group, dependency for #7054 (one test will fail without it)

Depends On:

+	~~7054 - Fix for commits without a parent not returning a diff~~

Groups:

+	students

git_repository_test.go (Diff revision 1)

Show all issues

If this is going to be a useful testing utility, maybe this should go in a seperate (testing.utils ?) package.

jyuen March 20, 2015, 12:17 a.m.

I put this in main_test.go. I'm still not 100% certain with the way Go organizes tests/code but it seems the trend is to have all test files correspond to a source .go file. git2go puts their utility test functions in their index_test.go file, so I think it makes sense to have rb-gateway use main_test.go. Hopefully I'm doing this right...

Change Summary:

Separate check_fatal function from git_respository_test.go

Commit:

-	ef5f71b71bd55c3571bf2532c6f9d8e527c9c550
+	b72c4c115d543811a226bd37e66ac9f6d87098b7

Diff:

Revision 2 (+349)

Show changes

	README.md
	git_repository_test.go
	main_test.go

Tool: Pyflakes
Ignored Files:
    git_repository_test.go
    main_test.go
    README.md



Tool: PEP8 Style Checker
Ignored Files:
    git_repository_test.go
    main_test.go
    README.md

git_repository_test.go (Diff revision 2)

Show all issues

If I run the tests on my mac, I get this:

--- FAIL: TestGetPath (0.01s)
    git_repository_test.go:126: Expected '/var/folders/lp/dyp18_2s6bj05n25pm0k0_880000gn/T/rb-gateway574450298/', got '/private/var/folders/lp/dyp18_2s6bj05n25pm0k0_880000gn/T/rb-gateway574450298/'


Which I think is happening because /var is a symbolic link to /private/var. Can you add a call to filepath.EvalSymlinks on the result of TempDir?

jyuen March 23, 2015, 11:28 p.m.

I made the change, can you verify that it works in your env? Thanks!

david March 25, 2015, 8:45 p.m.

Looks good!

$ go test -v
=== RUN TestGetName
--- PASS: TestGetName (0.01s)
=== RUN TestGetPath
--- PASS: TestGetPath (0.00s)
=== RUN TestGetFile
--- PASS: TestGetFile (0.01s)
=== RUN TestGetFileByCommit
--- PASS: TestGetFileByCommit (0.01s)
=== RUN TestFileExists
--- PASS: TestFileExists (0.01s)
=== RUN TestFileExistsByCommit
--- PASS: TestFileExistsByCommit (0.01s)
=== RUN TestGetBranches
--- PASS: TestGetBranches (0.02s)
=== RUN TestGetCommits
--- PASS: TestGetCommits (0.02s)
=== RUN TestGetCommit
--- PASS: TestGetCommit (0.01s)
PASS
ok      _/Users/david/Projects/rb-gateway   0.172s

git_repository_test.go (Diff revision 2)

Show all issues

All fake e-mail addresses should use "example.com" (which is reserved for tests and examples), rather than pointing to a real website.

Change Summary:

Addressing David's suggestions

Commit:

-	b72c4c115d543811a226bd37e66ac9f6d87098b7
+	bb00723dcafd47a7f9747dd36d84346fe6ad4c6a

Diff:

Revision 3 (+352)

Show changes

	README.md
	git_repository_test.go
	main_test.go

Tool: PEP8 Style Checker
Ignored Files:
    git_repository_test.go
    main_test.go
    README.md



Tool: Pyflakes
Ignored Files:
    git_repository_test.go
    main_test.go
    README.md

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (27f86a8)

You have a pending review.

Review Board 4.0.5 alpha 0 (dev)

Add unit tests for git repository functions

Change Summary:

Depends On:

Groups:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)

Change Summary: