Summary

Generate original files in diff commit histories

Review Request #7050 — Created March 12, 2015 and submitted March 13, 2015, 4:06 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

6d269d6...

Reviewers

Groups

reviewboard

People

Description

It is now possible to generate the original file for a FileDiff whose

source file was created or modified earlier in the series of uploaded

DiffCommits. This allows the diff viewer to show side by side diffs

in these cases. However, the diff viewer will still show more than one 

side by side diff in this case. This will be addressed in a later

patch.
This patch also allows the original and patched file API resources to

return the files in this case.

Testing Done

Ran unit tests.

Was able to view diffs in the diff viewer that depended on FileDiffs
previously uploaded.

Files

Issues

Description	From	Last Updated
How about breaking this out into a separate method?	david	March 12, 2015, 6:21 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 12, 2015, 6:27 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/diffutils.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/diffutils.py

Added Files:

reviewboard/diffviewer/diffutils.py (Diff revision 1)

The issue has been resolved. Show all issues

How about breaking this out into a separate method?

Testing Done:

		Ran unit tests.
	+
	+	Was able to view diffs in the diff viewer that depended on `FileDiff`s
	+	previously uploaded.

Diff:

Revision 2 (+98 -28)

Show changes

reviewboard/diffviewer/diffutils.py

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/diffutils.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/diffutils.py

reviewboard/diffviewer/diffutils.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Diff:

Revision 3 (+99 -28)

Show changes

reviewboard/diffviewer/diffutils.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/diffutils.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/diffutils.py

Description:: It is now possible to generate the original file for a FileDiff whose
source file was created or modified earlier in the series of uploaded
DiffCommits. This allows the diff viewer to show side by side diffs
~ in these cases. However, the diff viewer will show more than one
~ in these cases. However, the diff viewer will still show more than one
side by side diff in this case. This will be addressed in a later
patch.

This patch also allows the original and patched file API resources to
return the files in this case.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to dvcs (e11b381)

		It is now possible to generate the original file for a `FileDiff` whose
		source file was created or modified earlier in the series of uploaded
		`DiffCommits`. This allows the diff viewer to show side by side diffs
~		in these cases. However, the diff viewer will show more than one
	~	in these cases. However, the diff viewer will still show more than one
		side by side diff in this case. This will be addressed in a later
		patch.

		This patch also allows the original and patched file API resources to
		return the files in this case.