Don't use assertListEqual in unit tests
Review Request #7041 — Created March 10, 2015 and submitted
The `TestCase.assertListEquals` method is only available in Python 2.7+. We support Python 2.6+, so we compare the items of lists directly instead of the lists directly.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
If two lists have equal contents, an assertEqual should do the job, and even show diffs. I think assertListEqual just … |
 chipx86
|
-
-
rbtools/clients/tests.py (Diff revision 1) If two lists have equal contents, an
assertEqualshould do the job, and even show diffs. I thinkassertListEqualjust does a better job of the diffs, but I thinkassertEqualis the best option here, since we'll see the whole set at once in the error.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+1 -2) |
Tool: Pyflakes Processed Files: rbtools/clients/tests.py Tool: PEP8 Style Checker Processed Files: rbtools/clients/tests.py