Summary

Don't use assertListEqual in unit tests

Review Request #7041 — Created March 10, 2015 and submitted March 10, 2015, 2:09 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

52be0f2...

Reviewers

Groups

rbtools

People

Description

The `TestCase.assertListEquals` method is only available in Python 2.7+.
We support Python 2.6+, so we compare the items of lists directly
instead of the lists directly.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
If two lists have equal contents, an assertEqual should do the job, and even show diffs. I think assertListEqual just …	chipx86	March 10, 2015, 2:01 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py

rbtools/clients/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

If two lists have equal contents, an assertEqual should do the job, and even show diffs. I think assertListEqual just does a better job of the diffs, but I think assertEqual is the best option here, since we'll see the whole set at once in the error.

Commit:

f15f82a808f2a3977444c96164e3c4c7fafa907e

52be0f25f251905bd216c2869fbc5002443bd0b6

Diff:

Revision 2 (+1 -2)

Show changes

rbtools/clients/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.7.x (17248fb)