Support for individual commit validation
Review Request #7038 — Created March 10, 2015 and submitted
Refactor the
DiffCommitListResourceinto a mixin to allow commmit
behvaiour to be shared between the originalDiffCommitListResource
and the newValidateDiffCommitResource. This new resource is
responsible for validating a commit (the diff and the metadata) before
it is uploaded and added to the review request.This new validator is used to validate all commits as they are
uploaded. This replaces the old behaviour where only the diff was
validated (using theValidateDiffResource) but none of the metadata
was.
Ran unit tests.
Able to upload a review request with history and have its commits
validated.
| Description | From | Last Updated |
|---|---|---|
|
Col: 1 E302 expected 2 blank lines, found 1 |
 reviewbot
|
-
Tool: Pyflakes Processed Files: rbtools/commands/post.py rbtools/api/resource.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/post.py rbtools/api/resource.py
Change Summary:
Rebase off dvcs after master was merged in
Summary: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 3 (+156 -103) |
Tool: Pyflakes Processed Files: rbtools/commands/post.py rbtools/api/resource.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/post.py rbtools/api/resource.py