Support for individual commit validation

Review Request #7038 — Created March 9, 2015 and submitted

Information

RBTools
dvcs
98ece9c...

Reviewers

Refactor the DiffCommitListResource into a mixin to allow commmit
behvaiour to be shared between the original DiffCommitListResource
and the new ValidateDiffCommitResource. This new resource is
responsible for validating a commit (the diff and the metadata) before
it is uploaded and added to the review request.

This new validator is used to validate all commits as they are
uploaded. This replaces the old behaviour where only the diff was
validated (using the ValidateDiffResource) but none of the metadata
was.

Ran unit tests.

Able to upload a review request with history and have its commits
validated.

Description From Last Updated

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
        rbtools/api/resource.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/api/resource.py
    
    
  2. rbtools/api/resource.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
        rbtools/api/resource.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/api/resource.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/api/resource.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
        rbtools/api/resource.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to dvcs (f475c87)