Add resource to validate DiffCommits
Review Request #7037 — Created March 9, 2015 and submitted — Latest diff uploaded
The new
ValidateDiffCommitResource
is capable of validating the diffs
and metadata of a simple linear history (that is, one where each
commit's diff will apply cleanly to the tracking branch). This new
resource was created because the the commit metadata also has to be
verified and the desired behaviour is different enough from the
existingValidateDiffResource
that it warrants creating a new one
(otherwise the existingValidateDiffResource
would become needlessly
complicated).Previously,
DiffCommit
s created via theDiffCommitManager
's methods
were created even if thesave
parameter was set toFalse
. This is
now no longer the case.Fix a
flake8
violation in theDiffSetManager
.
Ran unit tests.
Able to upload a review request with history and have its commits
validated.