Add resource to validate DiffCommits

Review Request #7037 — Created March 9, 2015 and submitted

Information

Review Board
dvcs
94a32f2...

Reviewers

The new ValidateDiffCommitResource is capable of validating the diffs
and metadata of a simple linear history (that is, one where each
commit's diff will apply cleanly to the tracking branch). This new
resource was created because the the commit metadata also has to be
verified and the desired behaviour is different enough from the
existing ValidateDiffResource that it warrants creating a new one
(otherwise the existing ValidateDiffResource would become needlessly
complicated).

Previously, DiffCommits created via the DiffCommitManager's methods
were created even if the save parameter was set to False. This is
now no longer the case.

Fix a flake8 violation in the DiffSetManager.

Ran unit tests.

Able to upload a review request with history and have its commits
validated.

Description From Last Updated

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Blank line after this.

daviddavid

Leftover debug output?

daviddavid

Should we catch regular "Exception"?

daviddavid

Should be "Build"

daviddavid

Two blank lines.

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/forms.py
        reviewboard/webapi/resources/validation.py
        reviewboard/diffviewer/managers.py
        reviewboard/webapi/resources/validate_diff_commit.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/forms.py
        reviewboard/webapi/resources/validation.py
        reviewboard/diffviewer/managers.py
        reviewboard/webapi/resources/validate_diff_commit.py
    
    
  2. Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/forms.py
        reviewboard/webapi/resources/validation.py
        reviewboard/diffviewer/managers.py
        reviewboard/webapi/resources/validate_diff_commit.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/forms.py
        reviewboard/webapi/resources/validation.py
        reviewboard/diffviewer/managers.py
        reviewboard/webapi/resources/validate_diff_commit.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/forms.py
        reviewboard/webapi/resources/validation.py
        reviewboard/diffviewer/managers.py
        reviewboard/webapi/resources/validate_diff_commit.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/forms.py
        reviewboard/webapi/resources/validation.py
        reviewboard/diffviewer/managers.py
        reviewboard/webapi/resources/validate_diff_commit.py
    
    
  2. 
      
david
  1. 
      
  2. Show all issues

    Blank line after this.

  3. Show all issues

    Leftover debug output?

  4. Show all issues

    Should we catch regular "Exception"?

  5. Show all issues

    Should be "Build"

  6. Show all issues

    Two blank lines.

  7. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/forms.py
        reviewboard/webapi/resources/validation.py
        reviewboard/diffviewer/managers.py
        reviewboard/webapi/resources/validate_diff_commit.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/forms.py
        reviewboard/webapi/resources/validation.py
        reviewboard/diffviewer/managers.py
        reviewboard/webapi/resources/validate_diff_commit.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to dvcs (7ce69e1)