Summary

Add resource to validate DiffCommits

Review Request #7037 — Created March 9, 2015 and submitted March 10, 2015, 6:33 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

94a32f2...

Reviewers

Groups

reviewboard

People

Description

The new ValidateDiffCommitResource is capable of validating the diffs
and metadata of a simple linear history (that is, one where each
commit's diff will apply cleanly to the tracking branch). This new
resource was created because the the commit metadata also has to be
verified and the desired behaviour is different enough from the
existing ValidateDiffResource that it warrants creating a new one
(otherwise the existing ValidateDiffResource would become needlessly
complicated).

Previously, DiffCommits created via the DiffCommitManager's methods
were created even if the save parameter was set to False. This is
now no longer the case.

Fix a flake8 violation in the DiffSetManager.

Testing Done

Ran unit tests.

Able to upload a review request with history and have its commits
validated.

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 9, 2015, 6:53 p.m.
Blank line after this.	david	March 10, 2015, 4:50 p.m.
Leftover debug output?	david	March 10, 2015, 4:50 p.m.
Should we catch regular "Exception"?	david	March 10, 2015, 4:53 p.m.
Should be "Build"	david	March 10, 2015, 4:50 p.m.
Two blank lines.	david	March 10, 2015, 4:50 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/forms.py
    reviewboard/webapi/resources/validation.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff_commit.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/forms.py
    reviewboard/webapi/resources/validation.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff_commit.py

reviewboard/webapi/resources/validate_diff_commit.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Change Summary:

PEP8/pyflakes

Description:

		The new `ValidateDiffCommitResource` is capable of validating the diffs
		and metadata of a simple linear history (that is, one where each
		commit's diff will apply cleanly to the tracking branch). This new
		resource was created because the the commit metadata also has to be
		verified and the desired behaviour is different enough from the
		existing `ValidateDiffResource` that it warrants creating a new one
		(otherwise the existing `ValidateDiffResource` would become needlessly
		complicated).

		Previously, `DiffCommit`s created via the `DiffCommitManager`'s methods
		were created even if the `save` parameter was set to `False`. This is
		now no longer the case.
	+
	+	Fix a `flake8` violation in the `DiffSetManager`.

Diff:

Revision 2 (+203 -5)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/webapi/resources/validate_diff_commit.py
	reviewboard/webapi/resources/validation.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/forms.py
    reviewboard/webapi/resources/validation.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff_commit.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/forms.py
    reviewboard/webapi/resources/validation.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff_commit.py

Commit:

9b1281227214305ff53c165b5c8b39de9fa94b59

Diff:

Revision 3 (+203 -5)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/webapi/resources/validate_diff_commit.py
	reviewboard/webapi/resources/validation.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/forms.py
    reviewboard/webapi/resources/validation.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff_commit.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/forms.py
    reviewboard/webapi/resources/validation.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff_commit.py

reviewboard/webapi/resources/validate_diff_commit.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Blank line after this.
```
reviewboard/webapi/resources/validate_diff_commit.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Leftover debug output?
```
reviewboard/webapi/resources/validate_diff_commit.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Should we catch regular "Exception"?
```
reviewboard/webapi/resources/validate_diff_commit.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Should be "Build"
```
reviewboard/webapi/resources/validate_diff_commit.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Two blank lines.
```

Commit:

9b1281227214305ff53c165b5c8b39de9fa94b59

94a32f25fb00637b9090328c7214ca9a48a5f120

Diff:

Revision 4 (+213 -5)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/webapi/resources/validate_diff_commit.py
	reviewboard/webapi/resources/validation.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/forms.py
    reviewboard/webapi/resources/validation.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff_commit.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/forms.py
    reviewboard/webapi/resources/validation.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff_commit.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to dvcs (7ce69e1)