• 
      

    Do not save DiffSets when validating diffs

    Review Request #7035 — Created March 9, 2015 and submitted

    Information

    Review Board
    release-2.0.x

    Reviewers

    Previously, the DiffSetManager would create DiffSets via the
    model.Manager.create method and then optionally save the generated
    model. However, this method will always end up saving the model to the
    database. Now, we explicitly instantiate the model in the manager
    and optionally call the save method on it.

    Ran unit tests.

    Uploaded a review request that had its diff validated. Verified that
    only one DiffSet was created in the database.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/diffviewer/managers.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/diffviewer/managers.py
      
      
    2. 
        
    brennie
    david
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (24b3100)