Summary:

[WIP] Admin page for integrations.

Review Request #7034 — Created March 9, 2015 and discarded March 23, 2015, 6:18 a.m.

Information
Owner:	xuanyi
Repository:	Review Board
Branch:	master
Bugs:
Depends On:	~~6918~~
Reviewers
Groups:	reviewboard, students
People:

Description

This provide the admin page to manage integrations.

Update: March 15, 2015

Added admin.py for configuredIntegrations
Added template for integration and configuredIntegration view
Added update method to WebapiResouce for toggling of integrations
Added toggle and add new link event to configuredIntegration model

Update: March 18, 2015

Added mockup for the admin page UI

Testing Done

Files

Issues

Description	From	Last Updated
'reviewboard' imported but unused	reviewbot	March 22, 2015, 9:40 p.m.
Col: 5 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	March 22, 2015, 9:40 p.m.
Col: 6 W292 no newline at end of file	reviewbot	March 22, 2015, 9:40 p.m.
'Http404' imported but unused	reviewbot	March 22, 2015, 9:40 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	March 22, 2015, 9:40 p.m.
'patterns' imported but unused	reviewbot	March 22, 2015, 9:42 p.m.
'include' imported but unused	reviewbot	March 22, 2015, 9:42 p.m.
'ObjectDoesNotExist' imported but unused	reviewbot	March 22, 2015, 9:42 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	March 22, 2015, 9:42 p.m.
'reviewboard' imported but unused	reviewbot	March 22, 2015, 9:42 p.m.
Col: 5 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	March 22, 2015, 9:42 p.m.
'Http404' imported but unused	reviewbot	March 22, 2015, 9:42 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	March 22, 2015, 9:42 p.m.
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	March 22, 2015, 9:41 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/integrations/urls.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/__init__.py
    reviewboard/integrations/views.py
    reviewboard/urls.py
    reviewboard/integrations/models.py
    reviewboard/integrations/manager.py
    reviewboard/integrations/integration.py
    reviewboard/staticbundles.py
    reviewboard/webapi/resources/integration.py

Ignored Files:
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    reviewboard/templates/integrations/integration_list.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/integrations/urls.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/__init__.py
    reviewboard/integrations/views.py
    reviewboard/urls.py
    reviewboard/integrations/models.py
    reviewboard/integrations/manager.py
    reviewboard/integrations/integration.py
    reviewboard/staticbundles.py
    reviewboard/webapi/resources/integration.py

Ignored Files:
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    reviewboard/templates/integrations/integration_list.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js

reviewboard/__init__.py (Diff revision 1)
Show all issues
```
 'reviewboard' imported but unused
```

reviewboard/integrations/urls.py (Diff revision 1)

Show all issues

Col: 5
 E123 closing bracket does not match indentation of opening bracket's line

reviewboard/integrations/urls.py (Diff revision 1)
Show all issues
```
Col: 6
 W292 no newline at end of file
```
reviewboard/integrations/views.py (Diff revision 1)
Show all issues
```
 'Http404' imported but unused
```
reviewboard/integrations/views.py (Diff revision 1)
Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/webapi/resources/integration.py (Diff revision 1)
Show all issues
```
 'patterns' imported but unused
```
reviewboard/webapi/resources/integration.py (Diff revision 1)
Show all issues
```
 'include' imported but unused
```
reviewboard/webapi/resources/integration.py (Diff revision 1)
Show all issues
```
 'ObjectDoesNotExist' imported but unused
```
reviewboard/webapi/resources/integration.py (Diff revision 1)
Show all issues
```
Col: 5
 E303 too many blank lines (2)
```

Description:

		This provide the admin page to manage integrations.
	+
	+	Update: March 15, 2015
	+
	+	Added admin.py for configuredIntegrations
	+	Added template for integration and configuredIntegration view
	+	Added update method to WebapiResouce for toggling of integrations
	+	Added toggle and add new link event to configuredIntegration model

Commit:

-	19b9fd3d8af8a52a568a432c263d077e19beafa2
+	cbd30ea0fc9295fb71cb41a54e4f4defd9c0772c

Diff:

Revision 2 (+708 -6)

Show changes

	reviewboard/__init__.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/extensions/hooks.py
	reviewboard/integrations/admin.py
	reviewboard/integrations/manager.py
	reviewboard/integrations/models.py
	reviewboard/integrations/urls.py
	8 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/integrations/urls.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/__init__.py
    reviewboard/extensions/hooks.py
    reviewboard/webapi/resources/configured_integration.py
    reviewboard/staticbundles.py
    reviewboard/integrations/models.py
    reviewboard/integrations/manager.py
    reviewboard/urls.py
    reviewboard/integrations/views.py
    reviewboard/integrations/admin.py
    reviewboard/webapi/resources/integration.py

Ignored Files:
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    reviewboard/templates/integrations/integration_list.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/integrations/urls.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/__init__.py
    reviewboard/extensions/hooks.py
    reviewboard/webapi/resources/configured_integration.py
    reviewboard/staticbundles.py
    reviewboard/integrations/models.py
    reviewboard/integrations/manager.py
    reviewboard/urls.py
    reviewboard/integrations/views.py
    reviewboard/integrations/admin.py
    reviewboard/webapi/resources/integration.py

Ignored Files:
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js
    reviewboard/templates/integrations/integration_list.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js

reviewboard/__init__.py (Diff revision 2)
Show all issues
```
 'reviewboard' imported but unused
```

reviewboard/integrations/urls.py (Diff revision 2)

Show all issues

Col: 5
 E123 closing bracket does not match indentation of opening bracket's line

reviewboard/integrations/views.py (Diff revision 2)
Show all issues
```
 'Http404' imported but unused
```
reviewboard/integrations/views.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

Description:

		This provide the admin page to manage integrations.

		Update: March 15, 2015

		Added admin.py for configuredIntegrations
		Added template for integration and configuredIntegration view
		Added update method to WebapiResouce for toggling of integrations
		Added toggle and add new link event to configuredIntegration model
	+
	+	Update: March 18, 2015
	+
	+	Added mockup for the admin page UI

Added Files:

Removed Files:
Added Files:

Added Files:

Added Files:

Added Files:

Added Files:

Commit:

-	cbd30ea0fc9295fb71cb41a54e4f4defd9c0772c
+	d253f690f4bd3193223d3a1faffcdc91ba8f1a08

Diff:

Revision 3 (+957 -2)

Show changes

	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/integrations/admin.py
	reviewboard/integrations/urls.py
	reviewboard/integrations/views.py
	reviewboard/static/rb/css/pages/integration.less
	reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
	reviewboard/static/rb/js/integrations/views/integrationManagerView.js
	7 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/integrations/urls.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/integrations/views.py
    reviewboard/webapi/resources/configured_integration.py
    reviewboard/staticbundles.py
    reviewboard/webapi/resources/integration.py
    reviewboard/urls.py
    reviewboard/integrations/admin.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py
    reviewboard/integrations/urls.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/integrations/views.py
    reviewboard/webapi/resources/configured_integration.py
    reviewboard/staticbundles.py
    reviewboard/webapi/resources/integration.py
    reviewboard/urls.py
    reviewboard/integrations/admin.py

Ignored Files:
    reviewboard/static/rb/css/pages/integration.less
    reviewboard/templates/integrations/configure_integration.html
    reviewboard/templates/integrations/integration_list.html
    reviewboard/templates/admin/base_site.html
    reviewboard/static/rb/js/integrations/models/integrationManagerModel.js
    reviewboard/static/rb/js/integrations/views/integrationManagerView.js

reviewboard/integrations/views.py (Diff revision 3)

Show all issues

Col: 9
 E123 closing bracket does not match indentation of opening bracket's line

Review Board 6.0 beta 3 (dev)

[WIP] Admin page for integrations.

Description:

Commit:

Diff:

Description:

Added Files:

Removed Files:

Added Files:

Added Files:

Added Files:

Added Files:

Added Files:

Commit:

Diff:

Status: Discarded