Refactor diff uploading in API resources

Review Request #7016 — Created March 6, 2015 and submitted

Information

RBTools
master
e54b2fa...

Reviewers

The diff uploading portion of the DiffListResource and the
ValidateDiffResource has been refactored into a mixin that both
classes inherit from. The diff uploading logic of both classes was
identical and this patch reduces the amount of repeated code.

Ran unit tests.

Uploaded this review request.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/resource.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/resource.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/resource.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/api/resource.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/resource.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/api/resource.py
    
    
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (80b8615)
Loading...