Summary

Refactor diff uploading in API resources

Review Request #7016 — Created March 6, 2015 and submitted March 10, 2015, 11:25 a.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

e54b2fa...

Reviewers

Groups

rbtools

People

Description

The diff uploading portion of the DiffListResource and the
ValidateDiffResource has been refactored into a mixin that both
classes inherit from. The diff uploading logic of both classes was
identical and this patch reduces the amount of repeated code.

Testing Done

Ran unit tests.

Uploaded this review request.

Tool: Pyflakes
Processed Files:
    rbtools/api/resource.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/resource.py

Commit:

1d7623647e4272381b1f9354d66210ca344f64d4

f26048b3884bf12885f47d203b145fa2c4c301d2

Diff:

Revision 2 (+41 -32)

Show changes

rbtools/api/resource.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/resource.py



Tool: Pyflakes
Processed Files:
    rbtools/api/resource.py

Ship it!

```
Ship It!
```

Change Summary:

Rebase off master.

Commit:

f26048b3884bf12885f47d203b145fa2c4c301d2

e54b2fa9d1aef01aebdc2a7a3fd351852d2f6500

Diff:

Revision 3 (+43 -32)

Show changes

rbtools/api/resource.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/resource.py



Tool: Pyflakes
Processed Files:
    rbtools/api/resource.py

Status:: Completed
Change Summary:: Pushed to dvcs (80b8615)