Support base commit IDs for diff validation.
Review Request #7015 — Created March 6, 2015 and submitted
The diff validation resource didn't have any support for base commit
IDs, which broke posting diffs against Bitbucket repositories. It now
accepts abase_commit_idfield in the API, which will be passed to
DiffSetManager.create_from_upload.There's also a new capability, so that RBTools can determine whether to
validate diffs when it has abase_commit_idvalue.
Unit tests pass.
Change Summary:
Add the missing capabilities and tests.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+48 -2) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/test_validate_diff.py reviewboard/webapi/tests/test_root.py reviewboard/webapi/server_info.py reviewboard/webapi/tests/test_server_info.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/test_validate_diff.py reviewboard/webapi/tests/test_root.py reviewboard/webapi/server_info.py reviewboard/webapi/tests/test_server_info.py
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/test_validate_diff.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/test_validate_diff.py