Support base commit IDs for diff validation.

Review Request #7015 — Created March 6, 2015 and submitted

Information

Review Board
release-2.0.x
a5e7450...

Reviewers

The diff validation resource didn't have any support for base commit
IDs, which broke posting diffs against Bitbucket repositories. It now
accepts a base_commit_id field in the API, which will be passed to
DiffSetManager.create_from_upload.

There's also a new capability, so that RBTools can determine whether to
validate diffs when it has a base_commit_id value.

Unit tests pass.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/validate_diff.py
        reviewboard/webapi/tests/test_validate_diff.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/validate_diff.py
        reviewboard/webapi/tests/test_validate_diff.py
    
    
  2. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/validate_diff.py
        reviewboard/webapi/tests/test_validate_diff.py
        reviewboard/webapi/tests/test_root.py
        reviewboard/webapi/server_info.py
        reviewboard/webapi/tests/test_server_info.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/validate_diff.py
        reviewboard/webapi/tests/test_validate_diff.py
        reviewboard/webapi/tests/test_root.py
        reviewboard/webapi/server_info.py
        reviewboard/webapi/tests/test_server_info.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (7269c8f)