Refactor DiffProcessorMixin

Review Request #7014 — Created March 5, 2015 and submitted

Information

Review Board
dvcs
e9275ad...

Reviewers

The DiffProcessorMixin has been refactored into two classes: the
DiffManagerBase class, which is a base class for the creation of
DiffSets and DiffCommits; and the DiffProcessor, which handles
the creation of FileDiffs from raw diffs.

The logic is separated into these two classes so that in a future
patch the DiffCommitManager can provide a file existence checker
based on the currently existing DiffCommits in a DiffSet for diff
file validation.

Ran unit tests.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/managers.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/managers.py
        reviewboard/hostingsvcs/service.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/managers.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/managers.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (41017b6)
Loading...