Summary

Refactor DiffProcessorMixin

Review Request #7014 — Created March 5, 2015 and submitted March 6, 2015, 9:14 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

e9275ad...

Reviewers

Groups

reviewboard

People

Description

The DiffProcessorMixin has been refactored into two classes: the

DiffManagerBase class, which is a base class for the creation of

DiffSets and DiffCommits; and the DiffProcessor, which handles

the creation of FileDiffs from raw diffs.
The logic is separated into these two classes so that in a future

patch the DiffCommitManager can provide a file existence checker

based on the currently existing DiffCommits in a DiffSet for diff

file validation.

Testing Done

Ran unit tests.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/managers.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/managers.py
    reviewboard/hostingsvcs/service.py

Change Summary:

Whoops!

Commit:

840ff405b547b180987b56962f8d2a6dc39bff1a

e9275adbff82757110ee4714504adef54a355d45

Diff:

Revision 2 (+197 -177)

Show changes

reviewboard/diffviewer/managers.py

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/managers.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/managers.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to dvcs (41017b6)