Summary

FileProvider Modal UI for uploads

Review Request #7009 — Created March 6, 2015 and updated May 20, 2015, 6:44 p.m.

Information

Owner

VTL-Developer

Repository

Review Board

Branch

master

Bugs

Depends On

7140

Commit

0b72c92...

Reviewers

Groups

reviewboard, students

People

Description

In order to upload files with the FileProvider framework, a UI must be implemented to allow the user to interact with their file provider account. When a user selects Add File to upload a file, they will be presented with a modal with tabs to switch between two different types of upload: from local machine, from file provider. Uploading from local machine is the same old default upload mechanism.

When selecting upload from file provider, they would be presented with a new window to interact with their file provider. Things they can do are:
- switch between different accounts
- select a file to upload by clicking on it
- navigate through directories by double clicking them
- click on file/directory to display metadata for it on the side
- search for items in the file provider

There's also the caption and attachment history field as well, to match the current mechanism.

Testing Done

Manual testing of the UI and debugging to verify files.

Files

Issues

Description	From	Last Updated
Does this button become unclickable if the currently selected object is a folder?	brennie	April 1, 2015, 5:43 p.m.
Since one of the defaults is an object, you should be using a defaults function that returns a new object …	brennie	March 27, 2015, 7:20 a.m.
Could you document what this does?	brennie	March 18, 2015, 4:21 p.m.
If you are testing for undefined, you should explicitly do metaInfo === undefined.	brennie	March 18, 2015, 4:21 p.m.
Single quotes for all of these.	brennie	March 18, 2015, 4:21 p.m.
We don't use @param in our JS docs	brennie	March 18, 2015, 4:13 p.m.
No blank line here.	brennie	March 18, 2015, 4:14 p.m.
Blank line contains whitespace.	brennie	March 18, 2015, 4:15 p.m.
Only one var statement at the beginning of each function.	brennie	March 18, 2015, 4:18 p.m.
We only use one var statement at the top of each function	brennie	March 18, 2015, 4:18 p.m.
Can you line up the quote marks?	brennie	March 30, 2015, 2:37 p.m.
Missing semi-colon.	SU Sunxperous	April 27, 2015, 11:19 p.m.
Space after :.	SU Sunxperous	April 27, 2015, 11:20 p.m.
Should not have trailing comma.	SU Sunxperous	April 27, 2015, 11:22 p.m.
Are <!-- and --> supposed to be present?	SU Sunxperous	April 23, 2015, 10:17 a.m.
Not sure if inline-styles are recommended, but there should be a space after :.	SU Sunxperous	April 27, 2015, 11:37 p.m.
Should not have trailing comma.	SU Sunxperous	April 27, 2015, 11:22 p.m.
Should this line have additional indentation?	SU Sunxperous	April 27, 2015, 11:22 p.m.
Space betwen ){.	SU Sunxperous	April 27, 2015, 11:22 p.m.
Is this line break deliberate?	SU Sunxperous	April 27, 2015, 11:36 p.m.
Space before gettext.	SU Sunxperous	April 27, 2015, 11:24 p.m.
Could this be !== instead?	SU Sunxperous	April 27, 2015, 11:48 p.m.
Please align "value" with "name".	david	May 20, 2015, 6:44 p.m.
I'm not sure I understand what "Path Content" means.	david	May 20, 2015, 6:44 p.m.
We should use === here.	david	May 20, 2015, 6:44 p.m.
Should use ===.	david	May 20, 2015, 6:44 p.m.
Should use ===.	david	May 20, 2015, 6:44 p.m.
These should just be indented 4 spaces (and probably put .text() on the next line.	david	May 20, 2015, 6:44 p.m.
Should use ===	david	May 20, 2015, 6:44 p.m.
These should just be indented 4 spaces (and probably put .text() on the next line.	david	May 20, 2015, 6:44 p.m.
These should just be indented 4 spaces (and probably put .text() on the next line.	david	May 20, 2015, 6:44 p.m.
Should use ===	david	May 20, 2015, 6:44 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/css/mixins/style.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/css/mixins/style.less

Change Summary:

Added the new models to the staticbundle.py

Fixed my backbone models for FileProvider and FileProviderNode, to work and match the new changes.

Added more functionality for File Provider UI: Changing accounts, navigating, selecting items.

Updated the styling.

Commit:

-	d70f85e92deced13a68a53147e96fa03b1411e0c
+	19c82cee41a2241a02cdd85aacf944a41370a3d2

Diff:

Revision 2 (+501 -7)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/mixins/style.less
	reviewboard/static/rb/js/resources/models/fileProviderModel.js
	reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
	reviewboard/static/rb/js/views/uploadAttachmentView.js
	reviewboard/webapi/tests/test_file_provider.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/css/mixins/style.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/css/mixins/style.less

reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js (Diff revision 2)

The issue has been resolved. Show all issues

Since one of the defaults is an object, you should be using a defaults function that returns a new object each time it is called.
Also, please document each field as to its purpose.

reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Could you document what this does?
```
reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js (Diff revision 2)
The issue has been resolved. Show all issues
```
If you are testing for undefined, you should explicitly do metaInfo === undefined.
```

reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 2)

The issue has been resolved. Show all issues

Single quotes for all of these.

reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
We don't use @param in our JS docs
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line contains whitespace.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Only one var statement at the beginning of each function.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
We only use one var statement at the top of each function
```

Change Summary:

Made changes as suggested by reviews

Added search logic to show search results on the options for selection. Search result is displayed after 500ms after the last key up in the search field, or display the current path when search field is empty.

Started implementation of the display of metadata as options are selected.

Commit:

-	19c82cee41a2241a02cdd85aacf944a41370a3d2
+	bc05d18a0e119735da92451af920e4ae1f409f8d

Diff:

Revision 3 (+580 -8)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/mixins/style.less
	reviewboard/static/rb/js/pages/views/reviewablePageView.js
	reviewboard/static/rb/js/resources/models/fileProviderModel.js
	reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
	reviewboard/static/rb/js/views/uploadAttachmentView.js

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.js
    reviewboard/static/rb/css/mixins/style.less



Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.js
    reviewboard/static/rb/css/mixins/style.less

Change Summary:

Made changes as suggested by reviews.

Added model for file-providers from api calls to api/file-providers/

Re-did the display of metadata, moving parts of the logic from reviewboard/static/rb/js/resources/models/fileProviderNode.js to reviewboard/static/rb/js/views/uploadAttachmentView.js

Cleaned up the UI of metadata to follow "table-like" display

Added integration with GET calls to api/file-providers/ to help determine path_sep for file provider accounts, and other needed information.

Implementation of the display of metadata as options are selected.

Commit:

-	bc05d18a0e119735da92451af920e4ae1f409f8d
+	ce8820f3dba19a5d5baf53c1bcb206cc64c48823

Diff:

Revision 4 (+686 -11)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/mixins/style.less
	reviewboard/static/rb/js/pages/views/reviewablePageView.js
	reviewboard/static/rb/js/resources/models/fileProviderAccountModel.js
	reviewboard/static/rb/js/resources/models/fileProviderModel.js
	reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderAccountModel.js
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.js
    reviewboard/static/rb/css/mixins/style.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderAccountModel.js
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.js
    reviewboard/static/rb/css/mixins/style.less

Change Summary:

Added documentation for the models. Also updated models to get the id appropriately with attrToJsonMap.

Fixed bug with metadata staying around when moving between directories and accounts.

Path for metadata section only shows for search results to help distinguish which file is which.

Changed disable of highlights/selects with node options through CSS as opposed to JavaScript.

Clean up of code, with variable/name ordering and spacing.

Depends On:

+	7124 - FileProvider resource web API for providers

Commit:

-	ce8820f3dba19a5d5baf53c1bcb206cc64c48823
+	9afefd1da2f1de6615c2e93595c3c4be1c0770d5

Diff:

Revision 5 (+735 -11)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/mixins/style.less
	reviewboard/static/rb/js/pages/views/reviewablePageView.js
	reviewboard/static/rb/js/resources/models/fileProviderAccountModel.js
	reviewboard/static/rb/js/resources/models/fileProviderModel.js
	reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderAccountModel.js
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.js
    reviewboard/static/rb/css/mixins/style.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileProviderAccountModel.js
    reviewboard/static/rb/js/resources/models/fileProviderNodeModel.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/js/resources/models/fileProviderModel.js
    reviewboard/static/rb/js/pages/views/reviewablePageView.js
    reviewboard/static/rb/css/mixins/style.less

Change Summary:

Updated summary, description and testing done.

Summary:

-	[WIP] FileProvider Framework UI
+	[WIP] FileProvider Modal UI for uploads

Description:

~		In order to upload files with the FileProvider framework, a UI must be implemented to allow the user to select files from their online file provider, and as well add their account to ReviewBoard.
	~	In order to upload files with the FileProvider framework, a UI must be implemented to allow the user to interact with their file provider account. When a user selects `Add File` to upload a file, they will be presented with a modal with tabs to switch between two different types of upload: from local machine, from file provider. Uploading from local machine is the same old default upload mechanism.
	+
	+	When selecting upload from file provider, they would be presented with a new window to interact with their file provider. Things they can do are:
	+	- switch between different accounts
	+	- select a file to upload by clicking on it
	+	- navigate through directories by double clicking them
	+	- click on file/directory to display metadata for it on the side
	+	- search for items in the file provider
	+
	+	There's also the caption and attachment history field as well, to match the current mechanism.

Testing Done:

Manual testing of the UI and debugging to verify files.

Change Summary:

Added image of new version of the file provider ui

Added Files:

Commit #5 version of file provider modal ui (Revision 1)

The issue has been dropped. Show all issues

Does this button become unclickable if the currently selected object is a folder?

VTL-Developer March 30, 2015, 5:50 p.m.

Not sure if this is okay. With the normal upload from local, you can click the Upload button without selecting a file, and you'll get an error message from web api. I copied the same thing, when you upload without selecting a file (or selecting a folder) and click Upload, a similar error event would occur and a message would be displayed.

mike_conley March 30, 2015, 7:20 p.m.

That sounds like us letting the user get into trouble. I suggest filing a new bug for the original issue (making sure the Upload button is disabled if no file is selected).

Then, we should do what we can here to make sure "Upload" is only possible where it makes sense (a file is selected).

Just my 2 cents.

VTL-Developer March 30, 2015, 7:37 p.m.

<p>Seeing how the Upload button is a shared resource between between both frameworks. I don't know if I should tackle both, or create a bug report for both, or some sort of combination.</p>

<p>I forgot to mention that the error message would appear in the modal, with something like <code>"This field is required"</code>.</p>

mike_conley March 30, 2015, 7:40 p.m.

We should create a tracking bug for the first issue so that we don't forget about it, and then I suggest considering writing a patch that fixes it for both cases which will close the bug you filed.

Give us an estimate of how hard it would be to fix the upload UI issue for both types of uploads. If it puts you outside of likelihood (and let's be honest, UCOSP finishes really really really soon), perhaps split it out and fix it in a follow-up.

VTL-Developer April 1, 2015, 5:43 p.m.

Created an issue (https://code.google.com/p/reviewboard/issues/detail?id=3829) and submitted a patch (https://reviews.reviewboard.org/r/7149/) for the original implementation. If that patch goes through, I would add the disable to this patch.

brennie April 1, 2015, 8:41 p.m.
```
Awesome, I'll have a look at this!
```

reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 5)

The issue has been resolved. Show all issues

Can you line up the quote marks?

Change Summary:

Decoupled the backbone.js resources for file provider framework into another review request.

Updated in response to reviews made (lining of code, and errors).

Added new handling of displaying of error messages. It will show the correct messages for the correct displayed tab as neccessary.

Changed variable naming to include $ as neccessary for JQuery objects.

Commit:

-	9afefd1da2f1de6615c2e93595c3c4be1c0770d5
+	8fca452767f278aa13ee378f29a27fbf1c0f80e4

Diff:

Revision 6 (+629 -18)

Show changes

	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/mixins/style.less
	reviewboard/static/rb/js/views/uploadAttachmentView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less

Change Summary:

Changed Depends On and Summary.

Summary:

-	[WIP] FileProvider Modal UI for uploads
+	FileProvider Modal UI for uploads

Depends On:

-	7124 - FileProvider resource web API for providers
-	6948 - FileProvider WebApi interaction with file provider account
+	7140 - BackBone.JS Models for File Provider framework

Change Summary:

Updated documentations to be more explicit about what happens internally.

Added IDs for some inputs to allow easier look ups with JQuery, and cached common used look ups for future and faster usage.

Also changed some of the == equality checks to ===

Commit:

-	8fca452767f278aa13ee378f29a27fbf1c0f80e4
+	6980fcb7241b184786c7d94c581c2f29de15aa7f

Diff:

Revision 7 (+648 -18)

Show changes

	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/mixins/style.less
	reviewboard/static/rb/js/views/uploadAttachmentView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less

Just for some future inspiration (whether for you if you're continuing this, or us down the road), check out file https://www.filepicker.com/. They seem to do a good job with web-based file picker UI.

They have some demos that require linking up with an account, which I didn't want to do.. You can get a sense in the FTP section in the dialog when clicking "Pick File" at https://www.filepicker.com/documentation/file_ingestion/widgets/pick.

Change Summary:

Started to include disable/enable Upload button based on conditions. It checks whether it is okay to subit or not.

Removed some variables named self (where it equals to this, the view) as it is possible to make uses of contexts to use this.

Added more JQuery caching, and made the naming more pseudo-private.

Fixed slashes floating to right with rtl css. Adding ‎ into the html fixes it.

Removed path_sep logic.

Commit:

-	6980fcb7241b184786c7d94c581c2f29de15aa7f
+	01f938b77e435f49be0ad2a4bc8edf9e43f3671e

Diff:

Revision 8 (+659 -20)

Show changes

	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/mixins/style.less
	reviewboard/static/rb/js/views/uploadAttachmentView.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less

Change Summary:

Refactored the view of the select box and metadata, by extending a backbone collection and model, respectively. Each new extension is able to render its own view and have it appended/replace the current view.
Some variable clean-up and ordering. Also declared more cached JQuery variables.
Removed the function loadFileProviderAccounts, and had a fetchAll command load it instead.
Added proper sorting of the elements in a collection by using BackBone.js comparator.

Commit:

-	01f938b77e435f49be0ad2a4bc8edf9e43f3671e
+	f3b993dfb2d0d9bceb39392ad8040b08e1b91a6b

Diff:

Revision 9 (+677 -20)

Show changes

	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/mixins/style.less
	reviewboard/static/rb/js/views/uploadAttachmentView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less

Fix it!

reviewboard/static/rb/css/common.less (Diff revision 9)
The issue has been resolved. Show all issues
```
Missing semi-colon.
```
reviewboard/static/rb/css/common.less (Diff revision 9)
The issue has been resolved. Show all issues
```
Space after :.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 9)
The issue has been resolved. Show all issues
```
Should not have trailing comma.
```

reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 9)

An issue was opened. Show all issues

Are <!-- and --> supposed to be present?

VTL-Developer April 27, 2015, 11:48 p.m.

Kept the html comments to remove the white space in between the two divs. The white space would make the modal look weird normally.

reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 9)

The issue has been resolved. Show all issues

Not sure if inline-styles are recommended, but there should be a space after :.

VTL-Developer April 27, 2015, 11:48 p.m.

Added the white space. Is there any guideline with regards to inline-styles?

reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 9)
The issue has been resolved. Show all issues
```
Should not have trailing comma.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 9)
The issue has been resolved. Show all issues
```
Should this line have additional indentation?
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 9)
The issue has been resolved. Show all issues
```
Space betwen ){.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 9)
The issue has been resolved. Show all issues
```
Is this line break deliberate?
```
1. VT
  
  VTL-Developer April 27, 2015, 11:48 p.m.
  Removed line break, reordered the option variables.
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 9)
The issue has been resolved. Show all issues
```
Space before gettext.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 9)
The issue has been resolved. Show all issues
```
Could this be !== instead?
```

Change Summary:

Updated to the file picker to use single clicks as opposed to double click for navigating directories.

Only files would have their metadata shown on the right side.

The path would allow quick backwards navigation by clicking the directory in the path you would like to revisit. Each part in the path is a span that contains data to the path found in the file directory. Clicking on them (except the most recent) would make a call to the server to get a list of all files and directories found from the file provider.

Updated the css and javascript styling in response to reviews.

Updated _loadDir to use a collection as an input as opposed to a boolean to determine which collection to use.

Moved the logic of the path display update to _navigateDir. As user's navigate, the path would update accordingly by appending to or removing from the last part of the path, or rebuild from a given path.

Commit:

-	f3b993dfb2d0d9bceb39392ad8040b08e1b91a6b
+	0b72c922453fd95c7e96214d2970784001ab205c

Diff:

Revision 10 (+774 -20)

Show changes

	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/defs.less
	reviewboard/static/rb/css/mixins/style.less
	reviewboard/static/rb/js/views/uploadAttachmentView.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/mixins/style.less

Fix it!

reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
Please align "value" with "name".
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
I'm not sure I understand what "Path Content" means.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
We should use === here.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
Should use ===.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
Should use ===.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
These should just be indented 4 spaces (and probably put .text() on the next line.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
Should use ===
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
These should just be indented 4 spaces (and probably put .text() on the next line.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
These should just be indented 4 spaces (and probably put .text() on the next line.
```
reviewboard/static/rb/js/views/uploadAttachmentView.js (Diff revision 10)
An issue was opened. Show all issues
```
Should use ===
```

FileProvider Modal UI for uploads

Information

Reviewers

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Depends On:

Commit:

Diff:

Change Summary:

Summary:

Description:

Testing Done:

Change Summary:

Added Files:

Change Summary:

Commit:

Diff:

Change Summary:

Summary:

Depends On:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff: