Styles for JSONDictWidget in admin site.

Review Request #6998 — Created Feb. 28, 2015 and discarded

yyoud88
Review Board
master
6999
reviewboard, students
anselina, smacleod

As a part of the project "Improve Review Bot's admin interface" in https://reviewboard.hackpad.com/Student-Project-Ideas-bWzTgtBtq9f, this change adds styles for JSONDictWidget.
The actual implementation of the functionalities are in https://reviews.reviewboard.org/r/6999/

Browser test done:
1. go to http://localhost:8080/admin/extensions/reviewbotext.extension.ReviewBotExtension/db/reviewbotext/tool/
2. click one of the tools. for example, "PEP8 Style Checker"
3. see if existing profiles' "Tool settings" part is displayed well
4. click "Add another profile"
5. see if newly added profile's "Tool settings" part is displayed well

Some possible edge cases are:
1. there's no existing profiles
2. there's exactly one porfile

Loading file attachments...

Description From Last Updated

This can be a one-line comment e.g. /* JSON Widget */

brenniebrennie

Blank line between these.

brenniebrennie

Blank line between these.

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/pages/admin.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/pages/admin.less
    
    
  2. 
      
YY
YY
brennie
  1. 
      
  2. reviewboard/static/rb/css/pages/admin.less (Diff revision 1)
     
     
     
     

    This can be a one-line comment e.g.

    /* JSON Widget */
    
    1. All other comments look like
      
      /***************************************************************************
       * Webhook page
       ***************************************************************************/
      /****************************************************************************
       * Security checklist
       ****************************************************************************/
      
      So, I thought it's better to follow this style?
  3. reviewboard/static/rb/css/pages/admin.less (Diff revision 1)
     
     
     

    Blank line between these.

  4. reviewboard/static/rb/css/pages/admin.less (Diff revision 1)
     
     
     

    Blank line between these.

  5. 
      
YY
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/pages/admin.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/pages/admin.less
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
david
Review request changed

Status: Discarded

Loading...