Summary

Styles for JSONDictWidget in admin site.

Review Request #6998 — Created Feb. 28, 2015 and discarded Nov. 23, 2016, 12:38 a.m.

Information

Owner

yyoud88

Repository

Review Board

Branch

master

Bugs

Depends On

~~6999~~

Reviewers

Groups

reviewboard, students

People

anselina, smacleod

Description

As a part of the project "Improve Review Bot's admin interface" in https://reviewboard.hackpad.com/Student-Project-Ideas-bWzTgtBtq9f, this change adds styles for JSONDictWidget.
The actual implementation of the functionalities are in https://reviews.reviewboard.org/r/6999/

Testing Done

Browser test done:
1. go to http://localhost:8080/admin/extensions/reviewbotext.extension.ReviewBotExtension/db/reviewbotext/tool/
2. click one of the tools. for example, "PEP8 Style Checker"
3. see if existing profiles' "Tool settings" part is displayed well
4. click "Add another profile"
5. see if newly added profile's "Tool settings" part is displayed well

Some possible edge cases are:
1. there's no existing profiles
2. there's exactly one porfile

Files

Issues

Description	From	Last Updated
This can be a one-line comment e.g. /* JSON Widget */	brennie	March 14, 2015, 12:38 p.m.
Blank line between these.	brennie	March 14, 2015, 12:40 p.m.
Blank line between these.	brennie	March 14, 2015, 12:40 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/pages/admin.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/pages/admin.less

Groups:: students
People:: anselina
smacleod
Added Files:

Description:: ~
As a part of the project "Improve Review Bot's admin interface" in https://reviewboard.hackpad.com/Student-Project-Ideas-bWzTgtBtq9f, this change adds styles for JSONDictWidget.
~
As a part of the project "Improve Review Bot's admin interface" in https://reviewboard.hackpad.com/Student-Project-Ideas-bWzTgtBtq9f, this change adds styles for JSONDictWidget.
+ The actual implementation of the functionalities are in https://reviews.reviewboard.org/r/6999/
Depends On:: ~~6999 - Improve Review Bot's admin interface~~

Ship it!

reviewboard/static/rb/css/pages/admin.less (Diff revision 1)

The issue has been dropped. Show all issues

This can be a one-line comment e.g.

/* JSON Widget */

yyoud88 March 14, 2015, 12:40 p.m.

All other comments look like

/***************************************************************************
 * Webhook page
 ***************************************************************************/
/****************************************************************************
 * Security checklist
 ****************************************************************************/

So, I thought it's better to follow this style?

reviewboard/static/rb/css/pages/admin.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/static/rb/css/pages/admin.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Commit:

479f4d56599c442eb183279d19dbfc8bb5044cb4

2ac0523393452c27af9d082dd8c76f0b8a81cfb8

Diff:

Revision 2 (+23)

Show changes

reviewboard/static/rb/css/pages/admin.less

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/pages/admin.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/pages/admin.less

Ship it!

```
Ship It!
```

Status:: Discarded

~		As a part of the project "Improve Review Bot's admin interface" in https://reviewboard.hackpad.com/Student-Project-Ideas-bWzTgtBtq9f, this change adds styles for JSONDictWidget.
	~	As a part of the project "Improve Review Bot's admin interface" in https://reviewboard.hackpad.com/Student-Project-Ideas-bWzTgtBtq9f, this change adds styles for JSONDictWidget.
	+	The actual implementation of the functionalities are in https://reviews.reviewboard.org/r/6999/