Fix "Issue 3790: RB not able to open local git repo on Windows"

Review Request #6987 — Created Feb. 27, 2015 and submitted

Information

Review Board
master
a3a6419...

Reviewers

Windows needs the hard drive letter as prefix for a file.

I added a platform depended solution.

Tested on windows

Description From Last Updated

Col: 17 E265 block comment should start with '# '

reviewbotreviewbot

There's something wrong with your diff because this is the only line showing as modified.

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/git.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/git.py
    
    
  2. reviewboard/scmtools/git.py (Diff revision 1)
     
     
    Col: 17
     E265 block comment should start with '# '
    
  3. 
      
ST
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/git.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/git.py
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/scmtools/git.py (Diff revision 2)
     
     

    There's something wrong with your diff because this is the only line showing as modified.

    1. There is something wrong with reviewboard, because in diff viewer "orig - rev2" it does completely ignore rev1.

      Please have a look of the diff "orig - rev1" there the fix is done.

    2. Out of curiousity, how are you uploading your diff (i.e., what command are you using)? It looks like part of your change is getting uploaded as a parent diff.

    3. I saw the same problem from Stefan's other reviews

    4. I used rbt post -u REVISION-SHA

    5. I see, Stefan, you should just use rbt post -u

    6. Please use rbt post -u on all your other review requests as well so that the entire diff is uploaded. When you do rbt post -u <SHA>, it only posts a single commit for review. We want everything between master and your commit. :)

  3. 
      
ST
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/git.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/git.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
ST
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (9e2da0c)
Loading...