Summary

Fix "Issue 3790: RB not able to open local git repo on Windows"

Review Request #6987 — Created Feb. 27, 2015 and submitted March 3, 2015, 4:29 p.m.

Information

Owner

stefan

Repository

Review Board

Branch

master

Bugs

3790

Depends On

Commit

a3a6419...

Reviewers

Groups

reviewboard

People

Description

Windows needs the hard drive letter as prefix for a file.

I added a platform depended solution.

Testing Done

Tested on windows

Issues

Description	From	Last Updated
Col: 17 E265 block comment should start with '# '	reviewbot	Feb. 27, 2015, 6:59 a.m.
There's something wrong with your diff because this is the only line showing as modified.	brennie	March 1, 2015, 11:32 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/git.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/git.py

reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 17
 E265 block comment should start with '# '
```

Change Summary:

Fixed E265 block comment should start with '# '

Commit:

adf5fc02e21cda0e8e3edc1a6a8dab657f67be45

79d3bc8b1afa2005d0bd54dea6c213c41b00a174

Diff:

Revision 2 (+1 -1)

Show changes

reviewboard/scmtools/git.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/git.py



Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/git.py

reviewboard/scmtools/git.py (Diff revision 2)

The issue has been resolved. Show all issues

There's something wrong with your diff because this is the only line showing as modified.

stefan March 2, 2015, 4:11 a.m.

There is something wrong with reviewboard, because in diff viewer "orig - rev2" it does completely ignore rev1.

Please have a look of the diff "orig - rev1" there the fix is done.

brennie March 2, 2015, 6:13 a.m.

Out of curiousity, how are you uploading your diff (i.e., what command are you using)? It looks like part of your change is getting uploaded as a parent diff.

Chester March 2, 2015, 11:25 a.m.

I saw the same problem from Stefan's other reviews

ST

stefan March 2, 2015, 11:40 a.m.
```
I used rbt post -u REVISION-SHA
```

Chester March 2, 2015, 11:43 a.m.

I see, Stefan, you should just use rbt post -u

brennie March 2, 2015, 11:47 a.m.

Please use rbt post -u on all your other review requests as well so that the entire diff is uploaded. When you do rbt post -u <SHA>, it only posts a single commit for review. We want everything between master and your commit. :)

Change Summary:

Fix diff

Commit:

79d3bc8b1afa2005d0bd54dea6c213c41b00a174

a3a6419639c8a231444875de3b459f8ca8f60677

Diff:

Revision 3 (+6 -1)

Show changes

reviewboard/scmtools/git.py

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/git.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/git.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (9e2da0c)