• 
      

    Fix "Issue 3787: "TypeError: must be char, not unicode" when installing reviewboard on windows."

    Review Request #6983 — Created Feb. 27, 2015 and submitted — Latest diff uploaded

    Information

    Review Board
    master
    a28b28d...

    Reviewers

    Fix "Issue 3787: "TypeError: must be char, not unicode" when installing reviewboard on windows."

    Reviewboard does not display the diff: "original - rev 2" correctly.
    Please first have a look at the diff: "original - rev 1" to see the fixed problem.

    What's the URL of the page containing the problem?
    Reviewboard/cmdline/rbsite.py

    What steps will reproduce the problem?
    in windows command line:
    1. easy_install reviewboard
    2. rb-site install D:\reviewboard\www
    reviewboard will propt for the following variables
    1. Domain: "Domain"
    2. Path: "/reviewboard/"
    3. DB Name: "reviewboard"
    4. DB Server: "domain"
    5. DB User: "user"

    What is the expected output? What do you see instead?
    After step 2.5. the db password should be prompted
    Instead the exception is thrown.

    Please provide any additional information below.
    Traceback (most recent call last):
      File "C:\Python27\Scripts\rb-site-script.py", line 9, in <module>
        load_entry_point('ReviewBoard==2.0.13', 'console_scripts', 'rb-site')()
      File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1883, in main
        command.run()
      File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1225, in run
        self.ask_database_login()
      File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1438, in ask_database_login
        save_obj=site, save_var="db_pass")
      File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 942, in prompt_input
        temp_value = getpass.getpass(prompt)
      File "C:\Python27\lib\getpass.py", line 95, in win_getpass
        msvcrt.putch(c)
    TypeError: must be char, not unicode
    

    Verified execution in command line