Summary

Fix "Issue 3787: "TypeError: must be char, not unicode" when installing reviewboard on windows."

Review Request #6983 — Created Feb. 27, 2015 and submitted March 4, 2015, 1:23 p.m.

Information

Owner

stefan

Repository

Review Board

Branch

master

Bugs

3787

Depends On

Commit

a28b28d...

Reviewers

Groups

reviewboard

People

Description

Fix "Issue 3787: "TypeError: must be char, not unicode" when installing reviewboard on windows."

Reviewboard does not display the diff: "original - rev 2" correctly.
Please first have a look at the diff: "original - rev 1" to see the fixed problem.

What's the URL of the page containing the problem?
Reviewboard/cmdline/rbsite.py

What steps will reproduce the problem?
in windows command line:
1. easy_install reviewboard
2. rb-site install D:\reviewboard\www
reviewboard will propt for the following variables
1. Domain: "Domain"
2. Path: "/reviewboard/"
3. DB Name: "reviewboard"
4. DB Server: "domain"
5. DB User: "user"

What is the expected output? What do you see instead?
After step 2.5. the db password should be prompted
Instead the exception is thrown.

Please provide any additional information below.
Traceback (most recent call last):
  File "C:\Python27\Scripts\rb-site-script.py", line 9, in <module>
    load_entry_point('ReviewBoard==2.0.13', 'console_scripts', 'rb-site')()
  File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1883, in main
    command.run()
  File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1225, in run
    self.ask_database_login()
  File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1438, in ask_database_login
    save_obj=site, save_var="db_pass")
  File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 942, in prompt_input
    temp_value = getpass.getpass(prompt)
  File "C:\Python27\lib\getpass.py", line 95, in win_getpass
    msvcrt.putch(c)
TypeError: must be char, not unicode

Testing Done

Verified execution in command line

Issues

Description	From	Last Updated
Col: 52 E251 unexpected spaces around keyword / parameter equals	reviewbot	Feb. 27, 2015, 12:50 a.m.
Col: 54 E251 unexpected spaces around keyword / parameter equals	reviewbot	Feb. 27, 2015, 12:50 a.m.
Col: 76 E231 missing whitespace after ','	reviewbot	Feb. 27, 2015, 12:50 a.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	Feb. 27, 2015, 12:50 a.m.
Please sort these alphabetically.	david	March 4, 2015, 12:43 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py

reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 52
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 54
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 76
 E231 missing whitespace after ','
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (86 > 79 characters)
```

Change Summary:

Added bug no.

Bugs:

+	3787

Change Summary:

Fix code convention errors

Commit:

-	0542c5f2ded60dea4376e9acfee44a95b8eb23df
+	39458ddc5c8ca9ba7f8bff9bcda16c68742fa937

Diff:

Revision 2 (+2 -1)

Show changes

reviewboard/cmdline/rbsite.py

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py

Description:

		Fix "Issue 3787: "TypeError: must be char, not unicode" when installing reviewboard on windows."
	+
	+	Reviewboard does not display the diff: "original - rev 2" correctly.
	+	Please first have a look at the diff: "original - rev 1" to see the fixed problem.


Could you please modify the description to make it more clear?
Please add how the problem rises and why it can be solved by the change.
Would this change cause error(s) in other environments?
You should probably add a unit test for the change.
I also left some comments on the issue page.

stefan March 2, 2015, 11:40 a.m.

I do not know why it appears, but it is a common problem with getpass:
* https://code.djangoproject.com/ticket/19807
* https://code.djangoproject.com/ticket/22364
* https://bitbucket.org/ZyX_I/gibiexport/issue/2/error-getting-password-on-windows

I only have windows running and do not see a problem.

Unfortunately, I'm no pro at python and never wanted to be one. But since there were a few problems I just wanted to fix and contribute every problem I stumpled across. Therefore, I do not know how to test this thing.

Change Summary:

Additional info

Description:

		Fix "Issue 3787: "TypeError: must be char, not unicode" when installing reviewboard on windows."

		Reviewboard does not display the diff: "original - rev 2" correctly.
		Please first have a look at the diff: "original - rev 1" to see the fixed problem.
	+
	+	What's the URL of the page containing the problem?
	+	Reviewboard/cmdline/rbsite.py
	+
	+	What steps will reproduce the problem?
	+	in windows command line:
	+	1. easy_install reviewboard
	+	2. rb-site install D:\reviewboard\www
	+	reviewboard will propt for the following variables
	+	1. Domain: "Domain"
	+	2. Path: "/reviewboard/"
	+	3. DB Name: "reviewboard"
	+	4. DB Server: "domain"
	+	5. DB User: "user"
	+
	+	What is the expected output? What do you see instead?
	+	After step 2.5. the db password should be prompted
	+	Instead the exception is thrown.
	+
	+	`Please provide any additional information below.`
	+	Traceback (most recent call last):
	+	File "C:\Python27\Scripts\rb-site-script.py", line 9, in <module>
	+	load_entry_point('ReviewBoard==2.0.13', 'console_scripts', 'rb-site')()
	+	File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1883, in main
	+	command.run()
	+	File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1225, in run
	+	self.ask_database_login()
	+	File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1438, in ask_database_login
	+	save_obj=site, save_var="db_pass")
	+	File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 942, in prompt_input
	+	temp_value = getpass.getpass(prompt)
	+	File "C:\Python27\lib\getpass.py", line 95, in win_getpass
	+	msvcrt.putch(c)
	+	TypeError: must be char, not unicode
	+

Change Summary:

fix diff
(Solution derived from https://code.djangoproject.com/ticket/19807)

Commit:

-	39458ddc5c8ca9ba7f8bff9bcda16c68742fa937
+	ae944c8023d6015f725edf1eb6d01ef3e6df37b9

Diff:

Revision 3 (+2 -1)

Show changes

reviewboard/cmdline/rbsite.py

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py

Ship it!

reviewboard/cmdline/rbsite.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Please sort these alphabetically.
```

Change Summary:

Sort import alphabetically

Commit:

-	ae944c8023d6015f725edf1eb6d01ef3e6df37b9
+	a28b28d1c3acc89a2f12b325aaf2528480738672

Diff:

Revision 4 (+2 -1)

Show changes

reviewboard/cmdline/rbsite.py

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (d5c710a)