Fix "Issue 3787: "TypeError: must be char, not unicode" when installing reviewboard on windows."
Review Request #6983 — Created Feb. 27, 2015 and submitted
Fix "Issue 3787: "TypeError: must be char, not unicode" when installing reviewboard on windows."
Reviewboard does not display the diff: "original - rev 2" correctly.
Please first have a look at the diff: "original - rev 1" to see the fixed problem.What's the URL of the page containing the problem?
Reviewboard/cmdline/rbsite.pyWhat steps will reproduce the problem?
in windows command line:
1. easy_install reviewboard
2. rb-site install D:\reviewboard\www
reviewboard will propt for the following variables
1. Domain: "Domain"
2. Path: "/reviewboard/"
3. DB Name: "reviewboard"
4. DB Server: "domain"
5. DB User: "user"What is the expected output? What do you see instead?
After step 2.5. the db password should be prompted
Instead the exception is thrown.Please provide any additional information below. Traceback (most recent call last): File "C:\Python27\Scripts\rb-site-script.py", line 9, in <module> load_entry_point('ReviewBoard==2.0.13', 'console_scripts', 'rb-site')() File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1883, in main command.run() File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1225, in run self.ask_database_login() File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1438, in ask_database_login save_obj=site, save_var="db_pass") File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 942, in prompt_input temp_value = getpass.getpass(prompt) File "C:\Python27\lib\getpass.py", line 95, in win_getpass msvcrt.putch(c) TypeError: must be char, not unicode
Verified execution in command line
Description | From | Last Updated |
---|---|---|
Col: 52 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 54 E251 unexpected spaces around keyword / parameter equals |
![]() |
|
Col: 76 E231 missing whitespace after ',' |
![]() |
|
Col: 80 E501 line too long (86 > 79 characters) |
![]() |
|
Please sort these alphabetically. |
|
- Change Summary:
-
Added bug no.
- Bugs:
- Change Summary:
-
Fix code convention errors
- Commit:
-
0542c5f2ded60dea4376e9acfee44a95b8eb23df39458ddc5c8ca9ba7f8bff9bcda16c68742fa937
- Diff:
-
Revision 2 (+2 -1)
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
Tool: Pyflakes Processed Files: reviewboard/cmdline/rbsite.py Tool: PEP8 Style Checker Processed Files: reviewboard/cmdline/rbsite.py
-
- Could you please modify the description to make it more clear?
- Please add how the problem rises and why it can be solved by the change.
- Would this change cause error(s) in other environments?
- You should probably add a unit test for the change.
- I also left some comments on the issue page.
- Change Summary:
-
Additional info
- Description:
-
Fix "Issue 3787: "TypeError: must be char, not unicode" when installing reviewboard on windows."
Reviewboard does not display the diff: "original - rev 2" correctly.
Please first have a look at the diff: "original - rev 1" to see the fixed problem. + + What's the URL of the page containing the problem?
+ Reviewboard/cmdline/rbsite.py + + What steps will reproduce the problem?
+ in windows command line: + 1. easy_install reviewboard + 2. rb-site install D:\reviewboard\www + reviewboard will propt for the following variables + 1. Domain: "Domain" + 2. Path: "/reviewboard/" + 3. DB Name: "reviewboard" + 4. DB Server: "domain" + 5. DB User: "user" + + What is the expected output? What do you see instead?
+ After step 2.5. the db password should be prompted + Instead the exception is thrown. + + Please provide any additional information below.
+ Traceback (most recent call last):
+ File "C:\Python27\Scripts\rb-site-script.py", line 9, in <module>
+ load_entry_point('ReviewBoard==2.0.13', 'console_scripts', 'rb-site')()
+ File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1883, in main
+ command.run()
+ File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1225, in run
+ self.ask_database_login()
+ File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1438, in ask_database_login
+ save_obj=site, save_var="db_pass")
+ File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 942, in prompt_input
+ temp_value = getpass.getpass(prompt)
+ File "C:\Python27\lib\getpass.py", line 95, in win_getpass
+ msvcrt.putch(c)
+ TypeError: must be char, not unicode
+
- Change Summary:
-
fix diff (Solution derived from https://code.djangoproject.com/ticket/19807)
- Commit:
-
39458ddc5c8ca9ba7f8bff9bcda16c68742fa937ae944c8023d6015f725edf1eb6d01ef3e6df37b9
- Diff:
-
Revision 3 (+2 -1)
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
Tool: Pyflakes Processed Files: reviewboard/cmdline/rbsite.py Tool: PEP8 Style Checker Processed Files: reviewboard/cmdline/rbsite.py
- Change Summary:
-
Sort import alphabetically
- Commit:
-
ae944c8023d6015f725edf1eb6d01ef3e6df37b9a28b28d1c3acc89a2f12b325aaf2528480738672
- Diff:
-
Revision 4 (+2 -1)