Fix review request e-mail notifications with unicode in the summary.

Review Request #6976 — Created Feb. 24, 2015 and submitted

Information

Review Board
release-2.0.x
9cb2e10...

Reviewers

Publishing a review request with a summary that contains unicode would
sometimes fail with a UnicodeDecodeError, due to some code paths setting this
to an encoded string rather than a unicode object. I've changed the
notifications code to handle this correctly.

Added a unit test for this issue. The test fails before the change, and
succeeds after.

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/email.py
        reviewboard/notifications/tests.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/email.py
        reviewboard/notifications/tests.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (71a0423)
Loading...