Warnings caused by Condensed Diff upon db migration due to utf string comparison resolved

Review Request #6949 — Created Feb. 14, 2015 and submitted

rmeringe
Review Board
master
3698
047b1c1...
reviewboard

Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were occurring with utf strings rather than the pure bytestring.

Since the original problem occurred during migrations of the db server. I tried running a syncdb, and starting the development server. The warning disappeared after using the fix was made.

Description From Last Updated

This should use single quotes (b'').

brenniebrennie

local variable 'hashkey' is assigned to but never used

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
  2. 
      
david
  1. This should list a bug number, and the summary/description/testing done should follow the guidelines at https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/

  2. 
      
RM
david
  1. Almost there. Instead of listing the bug in the description, please put it in the "Bugs" field (on the right-hand side). The summary could also be more specific.

  2. 
      
RM
RM
RM
brennie
  1. 
      
  2. reviewboard/diffviewer/models.py (Diff revision 1)
     
     

    This should use single quotes (b'').

  3. 
      
RM
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
    
    
  2. reviewboard/diffviewer/models.py (Diff revision 2)
     
     
     local variable 'hashkey' is assigned to but never used
    
  3. reviewboard/diffviewer/models.py (Diff revision 2)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  4. 
      
brennie
  1. <p>There seems to be something missing from this patch because commit <code>33581a</code> does not exist in the repository and it looks like you only uploaded one commit.</p>
    <p>Make sure you aren't doing <code>rbt post -r 6949 <commit></code>, as this will only upload a single commit for review.</p>

    1. Hopefully this time it formats correctly:

      There seems to be something missing from this patch because commit 33581adoes not exist in the repository and it looks like you only uploaded one commit.

      Make sure you aren't doing rbt post -r 6949 <commit> as this will only upload a single commit for review.

    2. Actually, I think this review request is unnceccarry now. After I rebased I realized that the bug that was happening before due not comparing with the bytestring was replaced in the master branch with other code. Also the hashkey variable in line 244 is never used.

  2. 
      
brennie
  1. Hey Rohan, could you update this review request? If it is no longer necessary, please make sure to discard it.

  2. 
      
RM
Review request changed

Status: Closed (submitted)

Loading...