Summary

Warnings caused by Condensed Diff upon db migration due to utf string comparison resolved

Review Request #6949 — Created Feb. 14, 2015 and submitted April 28, 2015, 2:57 p.m.

Information

Owner

rmeringe

Repository

Review Board

Branch

master

Bugs

3698

Depends On

Commit

047b1c1...

Reviewers

Groups

reviewboard

People

Description

Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were occurring with utf strings rather than the pure bytestring.

Testing Done

Since the original problem occurred during migrations of the db server. I tried running a syncdb, and starting the development server. The warning disappeared after using the fix was made.

Issues

Description	From	Last Updated
This should use single quotes (b'').	brennie	March 22, 2015, 9:30 p.m.
local variable 'hashkey' is assigned to but never used	reviewbot	March 22, 2015, 9:30 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 9:30 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/models.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/models.py

This should list a bug number, and the summary/description/testing done should follow the guidelines at https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/

david March 13, 2015, 1:40 p.m.
```
Ping?
```

Change Summary:: Updated change Description and Testing to adhere to style guidelines
Description:: ~
Used comparison of bytestring rather than UTF string
~
Easy Fix Bug: 3698. Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were happening with utf strings rather than the pure bytestring.
Testing Done:: ~
Manual Testing of Development Server.
~
Since the original problem occurred during migrations of the db server. I tried running a syncdb, and starting the development server. The warning disappeared after using the fix was made.

Almost there. Instead of listing the bug in the description, please put it in the "Bugs" field (on the right-hand side). The summary could also be more specific.

Change Summary:: Updated summary, and moved bug description to appropriate field.
Summary:: Changed comparison of bytestring rather than UTF string
Warnings caused by Condensed Diff upon db migration due to utf string comparison resolved
Description:: ~
Easy Fix Bug: 3698. Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were happening with utf strings rather than the pure bytestring.
~
Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were happening with utf strings rather than the pure bytestring.
Bugs:: 3698, Fix, Bug:, Easy

Change Summary:: Updated summary, and moved bug description to appropriate field.
Description:: ~
Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were happening with utf strings rather than the pure bytestring.
~
Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were occurring with utf strings rather than the pure bytestring.

Change Summary:: Updated summary, and moved bug description to appropriate field.
Bugs:: Fix, Bug:, Easy

reviewboard/diffviewer/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should use single quotes (b'').
```

Change Summary:

Used single quotes instead of double quotes

Branch:

release-2.0.x

master

Commit:

8214eff6ebec09b5e53547aad407a9f47f186c08

047b1c152ebcd1db45576600344ae2b05fb37bc0

Diff:

Revision 2 (+3 -2)

Show changes

reviewboard/diffviewer/models.py

Fix it!

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/models.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/models.py

reviewboard/diffviewer/models.py (Diff revision 2)
An issue was opened. Show all issues
```
 local variable 'hashkey' is assigned to but never used
```
reviewboard/diffviewer/models.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

<p>There seems to be something missing from this patch because commit <code>33581a</code> does not exist in the repository and it looks like you only uploaded one commit.</p>

<p>Make sure you aren't doing <code>rbt post -r 6949 <commit></code>, as this will only upload a single commit for review.</p>

brennie March 23, 2015, 1 p.m.

Hopefully this time it formats correctly:

There seems to be something missing from this patch because commit 33581adoes not exist in the repository and it looks like you only uploaded one commit.

Make sure you aren't doing rbt post -r 6949 <commit> as this will only upload a single commit for review.

rmeringe March 23, 2015, 8:07 p.m.

Actually, I think this review request is unnceccarry now. After I rebased I realized that the bug that was happening before due not comparing with the bytestring was replaced in the master branch with other code. Also the hashkey variable in line 244 is never used.

Hey Rohan, could you update this review request? If it is no longer necessary, please make sure to discard it.

Status:: Completed

~		Used comparison of bytestring rather than UTF string
	~	Easy Fix Bug: 3698. Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were happening with utf strings rather than the pure bytestring.

~		Manual Testing of Development Server.
	~	Since the original problem occurred during migrations of the db server. I tried running a syncdb, and starting the development server. The warning disappeared after using the fix was made.

~		Easy Fix Bug: 3698. Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were happening with utf strings rather than the pure bytestring.
	~	Modified condensed diff in diffviewer to not give out warnings. Warnings were originally given out in the condensed diff function because comparisons of strings were happening with utf strings rather than the pure bytestring.