Load d3 and cal-heatmap via imports.

Review Request #6944 — Created Feb. 12, 2015 and submitted

david
student-sonar
master
b447c52...
student-sonar

I had been loading these libraries from a CDN because jspm was giving me
problems installing them, but the problem turned out to be iojs (now that I've
switched back to node, installing works just fine). We can therefore just load
cal-heatmap via js imports, and it will use require() to load d3 (which
System.js handles nicely).

Loaded various student views and saw that the calendar appeared correctly.

Description From Last Updated

What's the plan for this? Is there a build-script that swaps these at deploy-time?

mike_conleymike_conley
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        package.json
        index.html
        lib/frontend/x-student-view.js
        .gitignore
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        package.json
        index.html
        lib/frontend/x-student-view.js
        .gitignore
    
    
  2. 
      
mike_conley
  1. 
      
  2. index.html (Diff revision 1)
     
     
     
     
     
     

    What's the plan for this? Is there a build-script that swaps these at deploy-time?

    1. That's what I'm working on now.

    2. Alright, let's not block on that.

  3. 
      
mike_conley
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (ec9e278)
Loading...